[PATCH] sched: Fix task_tick_fair from disabling numa_balancing

From	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] sched: Fix task_tick_fair from disabling numa_balancing
Date	2015-10-02 04:30 +0200
Message-ID	<qeYgF-6Gl-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If static branch sched_numa_balancing is enabled, it should kickstart
numa_balancing through task_tick_numa(). However Commit 2a1ed24
("sched/numa: Convert sched_numa_balancing to a static_branch")
erroneously disables this.

Fix this anomaly by enabling task_tick_numa when static branch
sched_numa_balancing is enabled.

Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4df37a4..3bdc3da 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7881,7 +7881,7 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
 		entity_tick(cfs_rq, se, queued);
 	}
 
-	if (!static_branch_unlikely(&sched_numa_balancing))
+	if (static_branch_unlikely(&sched_numa_balancing))
 		task_tick_numa(rq, curr);
 }
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] sched: Fix task_tick_fair from disabling numa_balancing Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-10-02 04:30 +0200

csiph-web