Re: [PATCH 01/12] net: fec: avoid timespec use

From	Richard Cochran <richardcochran@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/12] net: fec: avoid timespec use
Date	2015-10-01 21:10 +0200
Message-ID	<qeRoS-56r-21@gated-at.bofh.it> (permalink)
References	<qenKa-3xS-3@gated-at.bofh.it> <qenKb-3xS-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 30, 2015 at 01:26:31PM +0200, Arnd Bergmann wrote:
> The fec_ptp_enable_pps uses an open-coded implementation of ns_to_timespec,
> which will be removed eventually as it is not y2038-safe on 32-bit
> architectures. Two more instances of the same code in this file were
> already converted to use the safe ns_to_timespec64 in commit 6630514fcee
> ("ptp: fec: use helpers for converting ns to timespec"), this changes
> the last one as well.
> 
> The seconds portion here is actually unused and we could just remove the
> timespec variable, but using ns_to_timespec64 can still be better as the
> implementation can be hand-optimized in the future.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Richard Cochran <richardcochran@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/12] net: fec: avoid timespec use Arnd Bergmann <arnd@arndb.de> - 2015-09-30 13:30 +0200
  Re: [PATCH 01/12] net: fec: avoid timespec use Richard Cochran <richardcochran@gmail.com> - 2015-10-01 21:10 +0200

csiph-web