Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c)

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c)
Date	2015-10-01 20:00 +0200
Message-ID	<qeQj7-3kO-7@gated-at.bofh.it> (permalink)
References	<qeG0p-4wY-9@gated-at.bofh.it> <qePZL-2Ya-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 01, 2015 at 10:39:32AM -0700, Randy Dunlap wrote:
> On 09/30/15 23:50, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20150930:
> > 
> 
> 
> on x86_64:
> 
> ../arch/x86/ras/mce_amd_inj.c: In function 'toggle_nb_mca_mst_cpu':
> ../arch/x86/ras/mce_amd_inj.c:214:42: warning: dereferencing 'void *' pointer [enabled by default]
>   struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
>                                           ^
> ../arch/x86/ras/mce_amd_inj.c:214:42: error: request for member 'misc' in something not a structure or union

Thanks Randy,

this is most likely due to us using node_to_amd_nb() - an AMD_NB
facility - but we're not depending on it. Does that help?

---
diff --git a/arch/x86/ras/Kconfig b/arch/x86/ras/Kconfig
index 10fea5fc821e..98b3ef750984 100644
--- a/arch/x86/ras/Kconfig
+++ b/arch/x86/ras/Kconfig
@@ -1,6 +1,6 @@
 config AMD_MCE_INJ
 	tristate "Simple MCE injection interface for AMD processors"
-	depends on RAS && EDAC_DECODE_MCE && DEBUG_FS
+	depends on RAS && EDAC_DECODE_MCE && DEBUG_FS && AMD_NB
 	default n
 	help
 	  This is a simple debugfs interface to inject MCEs and test different

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

linux-next: Tree for Oct 1 Stephen Rothwell <sfr@canb.auug.org.au> - 2015-10-01 09:00 +0200
  Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c) Borislav Petkov <bp@alien8.de> - 2015-10-01 20:00 +0200
    Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c) Randy Dunlap <rdunlap@infradead.org> - 2015-10-01 20:20 +0200
  Re: linux-next: Tree for Oct 1 (ipvs) Simon Horman <horms@verge.net.au> - 2015-10-02 02:50 +0200

csiph-web