Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237591

Re: [PATCH v4 1/5] gadget: Introduce the notifier functions

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 24, 2015 at 10:39:23AM -0700, Baolin Wang wrote:
> The usb charger framework is based on usb gadget. The usb charger
> need to be notified the state changing of usb gadget to confirm the
> usb charger state.
> 
> Thus this patch adds a notifier mechanism for usb gadget to report a
> event to usb charger when the usb gadget state is changed.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  drivers/usb/gadget/udc/udc-core.c | 32 ++++++++++++++++++++++++++++++++
>  include/linux/usb/gadget.h        | 18 ++++++++++++++++++
>  2 files changed, 50 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
> index f660afb..4238fc3 100644
> --- a/drivers/usb/gadget/udc/udc-core.c
> +++ b/drivers/usb/gadget/udc/udc-core.c
> @@ -129,6 +129,32 @@ void usb_gadget_giveback_request(struct usb_ep *ep,
>  }
>  EXPORT_SYMBOL_GPL(usb_gadget_giveback_request);
>  
> +int usb_gadget_register_notify(struct usb_gadget *gadget,
> +			       struct notifier_block *nb)
> +{
> +	int ret;
> +
> +	mutex_lock(&gadget->lock);
> +	ret = raw_notifier_chain_register(&gadget->nh, nb);
> +	mutex_unlock(&gadget->lock);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(usb_gadget_register_notify);
> +
> +int usb_gadget_unregister_notify(struct usb_gadget *gadget,
> +				 struct notifier_block *nb)
> +{
> +	int ret;
> +
> +	mutex_lock(&gadget->lock);
> +	ret = raw_notifier_chain_unregister(&gadget->nh, nb);

Greg, this is the kind of thing I wanted to avoid adding more of.

I was wondering if you would accept subsystems using kdbus for
this sort of notification. I'm okay waiting for kdbus for another
couple merge windows (if we have to) before that's merged, but
if we take this raw notifier approach now, we will end up having
to support it forever.

Also, because soon enough we will have to support USB Power Delivery
with Type C connector, this is bound to change in the coming months.

Frankly, I wanted all of this to be decided in userland with the
kernel just providing notification and basic safety checks (we don't
want to allow a bogus userspace daemon frying anybody's devices).

How would you feel about that ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/5] gadget: Introduce the notifier functions Baolin Wang <baolin.wang@linaro.org> - 2015-09-24 19:50 +0200
  Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-01 19:40 +0200
    Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-01 20:00 +0200
      Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-01 20:10 +0200
      Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Mark Brown <broonie@kernel.org> - 2015-10-02 18:50 +0200
        Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-02 19:30 +0200
          Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Mark Brown <broonie@kernel.org> - 2015-10-02 21:00 +0200
            Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-02 21:20 +0200
              Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Mark Brown <broonie@kernel.org> - 2015-10-05 01:00 +0200
                Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-05 17:20 +0200
                Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Mark Brown <broonie@kernel.org> - 2015-10-05 18:30 +0200
                Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-05 18:30 +0200
    Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Mark Brown <broonie@kernel.org> - 2015-10-01 20:00 +0200
    Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Greg KH <gregkh@linuxfoundation.org> - 2015-10-02 07:50 +0200
      Re: [PATCH v4 1/5] gadget: Introduce the notifier functions Felipe Balbi <balbi@ti.com> - 2015-10-02 19:30 +0200

csiph-web