Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1237487

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()
Date 2015-10-01 17:10 +0200
Message-ID <qeNEB-8aM-5@gated-at.bofh.it> (permalink)
References <qeiUa-53l-15@gated-at.bofh.it> <qeo3w-3UA-15@gated-at.bofh.it> <qeD2x-h5-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Oct 01, 2015 at 09:11:31AM +0530, Ronit Halder wrote:
> The existing dgap_parsefile() rejects invalid config file.
> But before we know that config file is invalid a lot of memory leak
> can happen. Removing the chances of memory leak won't heart anyone.
> 

Why not just reject it earlier instead of allocating more data?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: dgap: fix memory leak in dgap_parsefile() Ronit Halder <ronit.crj@gmail.com> - 2015-09-30 08:20 +0200
  Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile() Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-30 13:50 +0200
    Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile() Ronit Halder <ronit.crj@gmail.com> - 2015-10-01 05:50 +0200
      Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile() Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-01 17:10 +0200
        Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile() Ronit Halder <ronit.crj@gmail.com> - 2015-10-01 17:20 +0200

csiph-web