Re: [PATCH] ceph: fix message length computation

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Yan, Zheng" <ukernel@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ceph: fix message length computation
Date	Thu, 01 Oct 2015 15:50:02 +0200
Message-ID	<qeMpc-66l-3@gated-at.bofh.it> (permalink)
References	<qepiW-5S4-23@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Fp5e924H7XpkmBfhX0aeGlSF1htt6MTg5UI81jNFrjU=; b=yfYpCMa1CznV2PkeOHfGftLeka+xEkLaony4PGVHvIrisIkVBs58rA9n8waW0IDW0c pLWICqirdM9RbU3ZYTSSa2z1Po4iO0OS5+j8CQuSl1NkdqkPQvzHpdxEOQfmyTDu2rU+ 2LE135Qg/oXVlF3CqEOufIwhx8hDZpbvVB+/YohqgqkIUQDAmGLG9O4ghBhNrp5zGg3c 41Zh5pw7b9LOSbjPLAckCPWSBHxNoOT5L8iIteNariazeMxPMI5fjtflLGuuMISlJXyo IMfAAOSIe1Pdst43//tuecHXcmgbj5Yg+DXnJQ2D9jOujXkpWbSbpoBbPg7aOmyQ1hrF 8GPQ==
MIME-Version	1.0
X-Received	by 10.25.163.199 with SMTP id m190mr1955875lfe.13.1443706810058; Thu, 01 Oct 2015 06:40:10 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	ceph-devel <ceph-devel@vger.kernel.org>, y2038@lists.linaro.org, Ilya Dryomov <idryomov@gmail.com>, "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 1 Oct 2015 21:40:10 +0800
X-Original-Message-ID	<CAAM7YAm-YrSrYuNiUEC7z8t3FC0j+9bFs9Tdf4PpmRy5CojyqA@mail.gmail.com>
X-Original-References	<9959810.KasB66Ks40@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1237432

Show key headers only | View raw

On Wed, Sep 30, 2015 at 9:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> create_request_message() computes the maximum length of a message,
> but uses the wrong type for the time stamp: sizeof(struct timespec)
> may be 8 or 16 depending on the architecture, while sizeof(struct
> ceph_timespec) is always 8, and that is what gets put into the
> message.
>
> Found while auditing the uses of timespec for y2038 problems.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b8e69066d8af ("ceph: include time stamp in every MDS request")
> ---
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 51cb02da75d9..fe2c982764e7 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -1935,7 +1935,7 @@ static struct ceph_msg *create_request_message(struct ceph_mds_client *mdsc,
>
>         len = sizeof(*head) +
>                 pathlen1 + pathlen2 + 2*(1 + sizeof(u32) + sizeof(u64)) +
> -               sizeof(struct timespec);
> +               sizeof(struct ceph_timespec);
>
>         /* calculate (max) length for cap releases */
>         len += sizeof(struct ceph_mds_request_release) *
>

Applied. thanks

Yan, Zheng

> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ceph: fix message length computation Arnd Bergmann <arnd@arndb.de> - 2015-09-30 15:10 +0200
  Re: [PATCH] ceph: fix message length computation "Yan, Zheng" <ukernel@gmail.com> - 2015-10-01 15:50 +0200

csiph-web