Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237405

Re: [PATCH v1] perf report: Fix owner error when reading perf.data

Show all headers | View raw

Em Thu, Oct 01, 2015 at 09:26:26PM +0900, Taeung Song escreveu:
> > On Oct 1, 2015, at 6:10 PM, Ingo Molnar <mingo@kernel.org> wrote:
> > * Taeung Song <treeze.taeung@gmail.com> wrote:

> >> If perf.data file is owned by some user,
> >> it can't be read even if current user is root.

> > That's intentional: to keep a malicious local user from passing a perf.data to 
> > root who does 'perf report' accidentally or in the wrong directory.

> > root can copy or chown it to himself - or we could add some --really-force flag 
> > for that.

> I got it.
> I didn’t know its intention.

Feel free to transform Ingo's comment in a C source code comment right
besides the code doing that check, this way when someone else thinks
this is wrong, like you did, the comment will clarify things.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] perf report: Fix owner error when reading perf.data Taeung Song <treeze.taeung@gmail.com> - 2015-10-01 11:10 +0200
  Re: [PATCH v1] perf report: Fix owner error when reading perf.data Ingo Molnar <mingo@kernel.org> - 2015-10-01 11:20 +0200
    Re: [PATCH v1] perf report: Fix owner error when reading perf.data Taeung Song <treeze.taeung@gmail.com> - 2015-10-01 14:30 +0200
      Re: [PATCH v1] perf report: Fix owner error when reading perf.data Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-01 15:00 +0200

csiph-web