Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237370

Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits function

Show all headers | View raw

On Thu, 1 Oct 2015, Mark Brown wrote:

> On Thu, Oct 01, 2015 at 02:33:06AM -0400, jon@ringle.org wrote:
> 
> > @@ -2509,6 +2510,10 @@ static int _regmap_update_bits(struct regmap *map, unsigned int reg,
> >  	int ret;
> >  	unsigned int tmp, orig;
> >  
> > +	if (map->reg_update_bits)
> > +		return map->reg_update_bits(map->bus_context, reg, mask, val,
> > +					    change, force_write);
> > +
> >  	ret = _regmap_read(map, reg, &orig);
> >  	if (ret != 0)
> >  		return ret;
> 
> This completely bypasses and therefore breaks the cache infrastructure.
> 

Hi Mark,

Right after sending the v2 patch, I realized that calling the 
custom reg_update_bits would only be applicable for registers that are 
marked as volatile. Would the following solution be acceptable (it would 
also simplify the regmap_update_bits in the encx24j600 driver):

	if (regmap_volatile(map, reg) && map->reg_update_bits) {
		return map->reg_update_bits(map->bus_context, reg, mask, 
		                            val, change, force_write);
		
The cache state should not matter for volatile registers, right?

-Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] regmap: Allow installing custom reg_update_bits function jon@ringle.org - 2015-10-01 08:40 +0200
  Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits  function Mark Brown <broonie@kernel.org> - 2015-10-01 11:50 +0200
    Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits  function Jon Ringle <jon@ringle.org> - 2015-10-01 14:30 +0200
      Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits  function Mark Brown <broonie@kernel.org> - 2015-10-02 19:20 +0200

csiph-web