Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1237134

[PATCH v3 05/13] scsi: ufs: add quirk not to allow reset of interrupt aggregation

Show all headers | View raw

From: Seungwon Jeon <essuuj@gmail.com>

Some host controller supports interrupt aggregation, but doesn't
allow to reset counter and timer by s/w.

Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
 drivers/scsi/ufs/ufshcd.c |    3 ++-
 drivers/scsi/ufs/ufshcd.h |    6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index d41d57d..e388edc 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -3205,7 +3205,8 @@ static void ufshcd_transfer_req_compl(struct ufs_hba *hba)
 	 * false interrupt if device completes another request after resetting
 	 * aggregation and before reading the DB.
 	 */
-	if (ufshcd_is_intr_aggr_allowed(hba))
+	if (ufshcd_is_intr_aggr_allowed(hba) &&
+	    !(hba->quirks & UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR))
 		ufshcd_reset_intr_aggr(hba);
 
 	tr_doorbell = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 3702b92..0b185e1 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -471,6 +471,12 @@ struct ufs_hba {
 	 */
 	#define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR		UFS_BIT(7)
 
+	/*
+	 * This quirk needs to be enabled if host controller doesn't allow
+	 * that the interrupt aggregation timer and counter are reset by s/w.
+	 */
+	#define UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR		UFS_BIT(8)
+
 	unsigned int quirks;	/* Deviations from standard UFSHCI spec. */
 
 	wait_queue_head_t tm_wq;
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/13] exynos-ufs: add support for Exynos Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:20 +0200
  [PATCH v3 01/13] Documentation: samsung-phy: Add dt bindings for UFS Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:20 +0200
  [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
    Re: [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS  SoC kbuild test robot <lkp@intel.com> - 2015-10-01 10:50 +0200
    [PATCH] phy: exynos-ufs: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-10-01 10:50 +0200
    [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static kbuild test robot <lkp@intel.com> - 2015-10-01 13:10 +0200
    Re: [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS  SoC kbuild test robot <lkp@intel.com> - 2015-10-01 13:10 +0200
  [PATCH v3 06/13] scsi: ufs: add quirk to enable host controller  without hce Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 04/13] scsi: ufs: add quirk to fix mishandling  utrlclr/utmrlclr Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 03/13] scsi: ufs: add quirk to contain unconformable utrd  field Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 08/13] scsi: ufs: add add specific callback for hibern8 Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 07/13] scsi: ufs: add specific callback for nexus type Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
    Re: [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data kbuild test robot <lkp@intel.com> - 2015-10-01 12:10 +0200
  [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for  exynos UFS host controller Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
    Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Arnd Bergmann <arnd@arndb.de> - 2015-10-01 13:40 +0200
  [PATCH v3 05/13] scsi: ufs: add quirk not to allow reset of interrupt  aggregation Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 10/13] scsi: ufs: return value of pwr_change_notify Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  [PATCH v3 09/13] scsi: ufs: make ufshcd_config_pwr_mode of non-static  func Alim Akhtar <alim.akhtar@samsung.com> - 2015-10-01 10:30 +0200
  Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs Arnd Bergmann <arnd@arndb.de> - 2015-10-01 14:20 +0200

csiph-web