Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1237062

Re: [PATCH 2/8] mfd: arizona: Remove unneded ret variable

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/8] mfd: arizona: Remove unneded ret variable
Date 2015-10-01 09:20 +0200
Message-ID <qeGjM-58Q-15@gated-at.bofh.it> (permalink)
References <qe1gB-53J-3@gated-at.bofh.it> <qe1gB-53J-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:

> The ret variable is not needed since is not used in the
> function. Remove the variable and just return 0 instead.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/mfd/arizona-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 44cfdbb295db..acf354875338 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -69,8 +69,6 @@ EXPORT_SYMBOL_GPL(arizona_clk32k_enable);
>  
>  int arizona_clk32k_disable(struct arizona *arizona)
>  {
> -	int ret = 0;
> -
>  	mutex_lock(&arizona->clk_lock);
>  
>  	BUG_ON(arizona->clk32k_ref <= 0);
> @@ -90,7 +88,7 @@ int arizona_clk32k_disable(struct arizona *arizona)
>  
>  	mutex_unlock(&arizona->clk_lock);
>  
> -	return ret;
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(arizona_clk32k_disable);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 2/8] mfd: arizona: Remove unneded ret variable Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 13:30 +0200
  Re: [PATCH 2/8] mfd: arizona: Remove unneded ret variable Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-29 13:50 +0200
  Re: [PATCH 2/8] mfd: arizona: Remove unneded ret variable Lee Jones <lee.jones@linaro.org> - 2015-10-01 09:20 +0200

csiph-web