Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target
Date	2015-10-01 09:10 +0200
Message-ID	<qeGa5-4Xv-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <qbP0e-yp-17@gated-at.bofh.it> <qc0yl-Dj-7@gated-at.bofh.it> <qcI6m-40T-15@gated-at.bofh.it> <qeFnJ-3O7-15@gated-at.bofh.it> <qeG0q-4wY-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-10-01 at 08:50 +0200, Michal Marek wrote:
> On 2015-10-01 08:14, Michael Ellerman wrote:
> > On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote:
> >> Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a):
> >>> On 23 September 2015 19:50:52 GMT+10:00, Michal Marek
> >>> <mmarek@suse.com> wrote:
> >>>> On 2015-09-23 07:40, Michael Ellerman wrote:
> >>>>> +else ifneq ($(wildcard
> >>>> arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG)),)
> >>>>> @$(kecho) "*** Default configuration is based on
> >>>> '$(KBUILD_DEFCONFIG)'"
> >>>>> $(Q)$< $(silent)
> >>>> --defconfig=arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG) $(Kconfig)
> >>>>> +else +	@$(kecho) "*** Default configuration is based on target
> >>>> '$(KBUILD_DEFCONFIG)'"
> >>>>> +	$(Q)$(MAKE) -f $(srctree)/Makefile $(KBUILD_DEFCONFIG) endif
> >>>>
> >>>> What is the anticipated usage of this? The patch is not needed to
> >>>> make
> >>>>
> >>>> make ppc64le_defconfig
> >>>>
> >>>> work with the second patch. If it was, this would create a loop
> >>>> anyway.
> >>>
> >>> The idea is to make 'make defconfig' work when KBUILD_DEFCONFIG is
> >>> ppc64le_defconfig (which happens for us when uname returns ppc64le)
> >>> and additionally when ppc64le_defconfig is not a real file.
> >>
> >> Ah, that makes sense. You can add
> >>
> >> Acked-by: Michal Marek <mmarek@suse.com>
> >>
> >> if you want.
> > 
> > Thanks. I'll assume by that you mean you're happy if I take both patches
> > through the powerpc tree.
> 
> Yes, I assumed that this was your plan.

I didn't really have a plan :)

It's certainly easiest if I take it in my tree along with the new
ppc64le_defconfig, so I'll do that. Thanks.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target Michael Ellerman <mpe@ellerman.id.au> - 2015-09-23 07:50 +0200
  [RFC PATCH 2/2] powerpc: Add ppc64le_defconfig Michael Ellerman <mpe@ellerman.id.au> - 2015-09-23 07:50 +0200
    Re: [RFC,2/2] powerpc: Add ppc64le_defconfig Michael Ellerman <mpe@ellerman.id.au> - 2015-10-02 09:50 +0200
  Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG  to be a target Michal Marek <mmarek@suse.com> - 2015-09-23 12:00 +0200
    Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target Michael Ellerman <michael@ellerman.id.au> - 2015-09-24 00:20 +0200
      Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG  to be a target Michal Marek <mmarek@suse.com> - 2015-09-25 22:50 +0200
        Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow  KBUILD_DEFCONFIG to be a target Michael Ellerman <mpe@ellerman.id.au> - 2015-10-01 08:20 +0200
          Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG  to be a target Michal Marek <mmarek@suse.com> - 2015-10-01 09:00 +0200
            Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow  KBUILD_DEFCONFIG to be a target Michael Ellerman <mpe@ellerman.id.au> - 2015-10-01 09:10 +0200
  Re: [RFC, 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target Michael Ellerman <mpe@ellerman.id.au> - 2015-10-02 09:50 +0200

csiph-web