Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1235515

Re: [PATCH] mtd: nand: denali: max_banks calculation changed in revision 5.1

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Brian Norris <computersforpeace@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mtd: nand: denali: max_banks calculation changed in revision 5.1
Date Tue, 29 Sep 2015 22:00:02 +0200
Message-ID <qe9ea-7RT-15@gated-at.bofh.it> (permalink)
References <qe7YK-6an-25@gated-at.bofh.it> <qe7YK-6an-27@gated-at.bofh.it> <qe7YK-6an-23@gated-at.bofh.it>
X-Original-To Graham Moore <grmoore@opensource.altera.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wnxjFSo6OwFtS+/QP/uRxGhIKF9qdvaBXNoqN1JLcZs=; b=mQitl7TRRo+kyqdSpSpZLdr2ptrUbDlGnTyxExBI6Zx+1OchipRhvgqu9BBo8eZRgS sOv/ANpFT1j7QYNwJXMGpA0n6CeyGRtWz9bG1ibfwUBYeafiGXNzfIbvvVk2BNIXc2wt BWybov070YWbdYGYCKKLII8pDIEmiEzDwFbmOfx7c1zYB/SY4G/vAH+f5dunki2YBz+Q kvZyPvkp/gZFedsbaYAbEeFPqNEOwx5oJm0n0uwpZaQDysGubDZmhVoKuUaB1itEMvMD 5qVAvedBh08vcoIU+SgOhpE78n3LPRjQ4AyAkF/RLp27e1bQNWbTHmcmQRCMvw5rnJke 5ORg==
X-Received by 10.68.244.34 with SMTP id xd2mr34757097pbc.50.1443556611012; Tue, 29 Sep 2015 12:56:51 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
Organization linux.* mail to news gateway
X-Original-Cc linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>, linux-kernel@vger.kernel.org, Alan Tull <atull@opensource.altera.com>, Dinh Nguyen <dinguyen@opensource.altera.com>, Yves Vandervennet <yvanderv@opensource.altera.com>, Enrico Jorns <ejo@pengutronix.de>
X-Original-Date Tue, 29 Sep 2015 12:56:48 -0700
X-Original-Message-ID <20150929195648.GG31505@google.com>
X-Original-References <1437489571-916-1-git-send-email-grmoore@opensource.altera.com> <560AA7B6.3010505@opensource.altera.com> <20150929183121.GC31505@google.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1235515

Show key headers only | View raw


On Tue, Sep 29, 2015 at 11:31:21AM -0700, Brian Norris wrote:
> On Tue, Sep 29, 2015 at 10:01:10AM -0500, Graham Moore wrote:
> > On 07/21/2015 09:39 AM, Graham Moore wrote:
> > >diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> > >index 870c7fc..a98b41e 100644
> > >--- a/drivers/mtd/nand/denali.h
> > >+++ b/drivers/mtd/nand/denali.h
> > >@@ -178,6 +178,8 @@
> > >
> > >  #define REVISION				0x370
> > >  #define     REVISION__VALUE				0xffff
> > >+#define MAKE_COMPARABLE_REVISION(x)		swab16(x & REVISION__VALUE)
> 
> It's probably best to add parentheses around the 'x'.
> 
> > >+#define REVISION_5_1				0x00000501
> > >
> > >  #define ONFI_DEVICE_FEATURES			0x380
> > >  #define     ONFI_DEVICE_FEATURES__VALUE			0x003f
> > >
> > 
> 
> I can fix that up and apply, if no objections.

Pushed to l2-mtd.git with that fixup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] mtd: nand: denali: max_banks calculation changed in  revision 5.1 Brian Norris <computersforpeace@gmail.com> - 2015-09-29 20:40 +0200
  Re: [PATCH] mtd: nand: denali: max_banks calculation changed in  revision 5.1 Brian Norris <computersforpeace@gmail.com> - 2015-09-29 22:00 +0200

csiph-web