Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1235467

Re: [PATCH 1/3] kernel/audit: audit_dummy_context can be boolean

From Paul Moore <paul@paul-moore.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/3] kernel/audit: audit_dummy_context can be boolean
Date 2015-09-29 20:30 +0200
Message-ID <qe7P4-5Ze-13@gated-at.bofh.it> (permalink)
References <qe3V8-rR-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tuesday, September 29, 2015 10:15:39 PM Yaowei Bai wrote:
> This patch makes audit_dummy_context return bool due to this
> particular function only using either one or zero as its return
> value.
> 
> No functional change.
> 
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> ---
>  include/linux/audit.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied.

> diff --git a/include/linux/audit.h b/include/linux/audit.h
> index b2abc99..69844b6 100644
> --- a/include/linux/audit.h
> +++ b/include/linux/audit.h
> @@ -143,7 +143,7 @@ extern void __audit_inode_child(const struct inode
> *parent, extern void __audit_seccomp(unsigned long syscall, long signr, int
> code); extern void __audit_ptrace(struct task_struct *t);
> 
> -static inline int audit_dummy_context(void)
> +static inline bool audit_dummy_context(void)
>  {
>  	void *p = current->audit_context;
>  	return !p || *(int *)p;
> @@ -345,9 +345,9 @@ static inline void audit_syscall_entry(int major,
> unsigned long a0, { }
>  static inline void audit_syscall_exit(void *pt_regs)
>  { }
> -static inline int audit_dummy_context(void)
> +static inline bool audit_dummy_context(void)
>  {
> -	return 1;
> +	return true;
>  }
>  static inline struct filename *audit_reusename(const __user char *name)
>  {

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] kernel/audit: audit_dummy_context can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:20 +0200
  [PATCH 3/3] kernel/audit: audit_tree_match can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:20 +0200
    Re: [PATCH 3/3] kernel/audit: audit_tree_match can be boolean Paul Moore <paul@paul-moore.com> - 2015-09-29 20:50 +0200
  [PATCH 2/3] kernel/audit: audit_string_contains_control can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:20 +0200
    Re: [PATCH 2/3] kernel/audit: audit_string_contains_control can be boolean Paul Moore <paul@paul-moore.com> - 2015-09-29 20:40 +0200
  Re: [PATCH 1/3] kernel/audit: audit_dummy_context can be boolean Paul Moore <paul@paul-moore.com> - 2015-09-29 20:30 +0200

csiph-web