Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235382

Re: [PATCH] ver_linux: uniform output across various linux distros

Show all headers | View raw

On Tue, Sep 29, 2015 at 06:36:12PM +0300, Alexander Kapshuk wrote:
> I've reread 'Documentation/SubmittingPatches', and opted for method 1
> to create the patch.
> 
> When you mentioned about the patch changing the formatting, were you
> referring to the formatting of the actual script, or the output the
> script generated? If it's the former, I'm not sure I'm clear on how to
> keep separate the changes made to the code base from the changes in
> the formatting of the new code base introduced by these changes. If
> it's the latter, the overall output generated by the script is mostly
> identical to that generated by the original implementation.
> 
> If the patch below is still off the mark, I apologise for that, and
> would appreciate being pointed out what else needs changing, when you
> have the time. I understand you having more pressing matters to attend
> to.
> 
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>

This is the "oddest" changelog comments I've ever seen for a patch, it
doesn't describe what it is doing at all :)

Please fix up, and resend the whole thing correctly, so we can review
that.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ver_linux: uniform output across various linux distros Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2015-09-29 17:40 +0200
  Re: [PATCH] ver_linux: uniform output across various linux distros Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 18:50 +0200

csiph-web