Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1235316

Re: [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count
Date 2015-09-29 17:50 +0200
Message-ID <qe5kf-2lV-35@gated-at.bofh.it> (permalink)
References <qdZHQ-2IS-3@gated-at.bofh.it> <qdZHR-2IS-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 29 Sep 2015 11:28:34 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> With the introduction of the context switch preempt_count invariant,
> and the demise of PREEMPT_ACTIVE, its pointless to save/restore the
> per-cpu preemption count, it must always be 2.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Should we add a warn on someplace:

 WARN_ON_ONCE(preempt_count() != 2)

?

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count Peter Zijlstra <peterz@infradead.org> - 2015-09-29 11:50 +0200
  Re: [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count Steven Rostedt <rostedt@goodmis.org> - 2015-09-29 17:50 +0200
    Re: [RFC][PATCH 09/11] sched, x86: Kill saved_preempt_count Peter Zijlstra <peterz@infradead.org> - 2015-09-29 18:00 +0200

csiph-web