Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule()

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule()
Date	2015-09-29 17:40 +0200
Message-ID	<qe5aA-2aq-69@gated-at.bofh.it> (permalink)
References	<qdZHQ-2IS-3@gated-at.bofh.it> <qdZHS-2IS-43@gated-at.bofh.it> <qe50T-1Za-41@gated-at.bofh.it> <qe5aA-2aq-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 29, 2015 at 11:30:26AM -0400, Steven Rostedt wrote:
> On Tue, 29 Sep 2015 11:28:39 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Tue, 29 Sep 2015 11:28:30 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > There is only a single PREEMPT_ACTIVE use in the regular __schedule()
> > > path and that is to circumvent the task->state check. Since the code
> > > setting PREEMPT_ACTIVE is the immediate caller of __schedule() we can
> > > replace this with a function argument.
> > > 
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > > ---
> > 
> > Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
> 
> I just want to note that this scared me at first, because __schedule()
> can be traced by the function tracer that can also do a

See 11/11 :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Peter Zijlstra <peterz@infradead.org> - 2015-09-29 11:50 +0200
  Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Frederic Weisbecker <fweisbec@gmail.com> - 2015-09-29 15:20 +0200
  Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Steven Rostedt <rostedt@goodmis.org> - 2015-09-29 17:30 +0200
    Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Steven Rostedt <rostedt@goodmis.org> - 2015-09-29 17:40 +0200
      Re: [RFC][PATCH 05/11] sched: Add preempt argument to __schedule() Peter Zijlstra <peterz@infradead.org> - 2015-09-29 17:40 +0200

csiph-web