Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1235351

Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets
Date 2015-09-29 18:10 +0200
Message-ID <qe5DB-2XB-29@gated-at.bofh.it> (permalink)
References <qbt9n-2KM-9@gated-at.bofh.it> <qbV5D-13M-5@gated-at.bofh.it> <qbV5D-13M-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 23 Sep 2015, Oleksij Rempel wrote:

Subject: irqchip/mxs: ..... Please

> +struct icoll_priv {
> +	void __iomem *vector;
> +	void __iomem *levelack;
> +	void __iomem *ctrl;
> +	void __iomem *stat;
> +	void __iomem *intr;
> +	/* number of interrupts per register */
> +	int intr_per_reg;

Why are you adding this here just to remove it in the next patch?

> +	void __iomem *clear;

Please do not add members which are not required for the preparatory
step.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 2/2] ARM: irqchip: mxs: add Alphascale ASM9260  support Thomas Gleixner <tglx@linutronix.de> - 2015-09-22 12:40 +0200
  [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-09-23 18:30 +0200
    Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with  different offsets Thomas Gleixner <tglx@linutronix.de> - 2015-09-29 18:10 +0200
      [PATCH v5 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel <linux@rempel-privat.de> - 2015-10-05 21:10 +0200
        [PATCH v5 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel <linux@rempel-privat.de> - 2015-10-05 21:10 +0200
        [PATCH v5 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel <linux@rempel-privat.de> - 2015-10-05 21:10 +0200
  [PATCH v4 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel <linux@rempel-privat.de> - 2015-09-23 18:30 +0200
    [PATCH v4 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel <linux@rempel-privat.de> - 2015-09-23 18:30 +0200

csiph-web