Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235189

[PATCH 5/8] kernel/ring_buffer: rb_per_cpu_empty can be boolean

Show all headers | View raw

This patch makes rb_per_cpu_empty return bool to improve readability.

No functional change.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
 kernel/trace/ring_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index fc9ce12..a228789 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -3039,7 +3039,7 @@ int ring_buffer_write(struct ring_buffer *buffer,
 }
 EXPORT_SYMBOL_GPL(ring_buffer_write);
 
-static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
+static bool rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
 {
 	struct buffer_page *reader = cpu_buffer->reader_page;
 	struct buffer_page *head = rb_set_head_page(cpu_buffer);
@@ -3047,7 +3047,7 @@ static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
 
 	/* In case of error, head will be NULL */
 	if (unlikely(!head))
-		return 1;
+		return true;
 
 	return reader->read == rb_page_commit(reader) &&
 		(commit == reader ||
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] cleanups for trace Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 4/8] kernel/ring_buffer: ring_buffer_empty{cpu} can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 2/8] kernel/trace: report_latency in trace_irqsoff.c can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 8/8] kernel/trace: ftrace_event_is_function can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 1/8] kernel/trace: report_latency in trace_sched_wakeup.c can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 6/8] kernel/trace: rb_event_is_commit can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 5/8] kernel/ring_buffer: rb_per_cpu_empty can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 7/8] kernel/trace: is_legal_op can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200
  [PATCH 3/8] kernel/trace: rb_is_reader_page can be boolean Yaowei Bai <bywxiaobai@163.com> - 2015-09-29 16:50 +0200

csiph-web