Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235218

Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer

Show all headers | View raw

On 28/09/15 14:05, Alexander Stein wrote:
> Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
> Documentation/ABI/testing/sysfs-class-net does not state if this shall be
> signed or unsigned.
> Also remove the now unused variable fmt_udec.
[...]
> -			ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd));
> +			ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));

If we print anything numeric, why is zero not appropriate
(which would still be unsigned)?
-- 
Cheers,
     Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] net sysfs: Print link speed as signed integer Alexander Stein <alexander.stein@systec-electronic.com> - 2015-09-28 15:10 +0200
  Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer Jeremy Harris <jgh@redhat.com> - 2015-09-29 17:20 +0200
  Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer David Miller <davem@davemloft.net> - 2015-09-30 00:00 +0200

csiph-web