leds: inconsistent use of EXPORT_SYMBOL_* macros

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	leds: inconsistent use of EXPORT_SYMBOL_* macros
Date	2015-09-29 15:40 +0200
Message-ID	<qe3ip-7Ue-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus,

In drivers/leds/led-core.c some symbols are exported with
EXPORT_SYMBOL and other with EXPORT_SYMBOL_GPL macros.

It seems that this mess wasn't introduced intentionally, but rather
carelessly, as in case of led_blink_set() and led_stop_software_blink()
functions, where the former, which enables blinking, is exported with
EXPORT_SYMBOL, and the latter, which disables blinking, with
EXPORT_SYMBOL_GPL.

It is also worth of noting that all symbols in drivers/led/led-class.c
are exported with EXPORT_SYMBOL_GPL, which implies that it is not
possible to register LED class device with non-GPL API, which in
turn rather eliminates non-GPL users of led-core API.

I'd like just confirm that in this case we are permitted to
switch to using EXPORT_SYMBOL_GPL consequently in the LED core.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

leds: inconsistent use of EXPORT_SYMBOL_* macros Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-29 15:40 +0200

csiph-web