Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234988
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 6/8] mfd: da903x: Simplify function return logic |
| Date | 2015-09-29 13:30 +0200 |
| Message-ID | <qe1gD-53J-35@gated-at.bofh.it> (permalink) |
| References | <qe1gB-53J-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The invoked function already returns zero on success or a negative errno code so there is no need to open code the logic in the caller. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/mfd/da903x.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c index ef7fe2ae2fa4..37e4426ef061 100644 --- a/drivers/mfd/da903x.c +++ b/drivers/mfd/da903x.c @@ -532,11 +532,7 @@ static int da903x_probe(struct i2c_client *client, return ret; } - ret = da903x_add_subdevs(chip, pdata); - if (ret) - return ret; - - return 0; + return da903x_add_subdevs(chip, pdata); } static int da903x_remove(struct i2c_client *client) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] mfd: Simplify return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 13:30 +0200
[PATCH 6/8] mfd: da903x: Simplify function return logic Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-29 13:30 +0200
RE: [PATCH 6/8] mfd: da903x: Simplify function return logic "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-09-29 14:30 +0200
csiph-web