Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234955
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH 12/11] sched: Add preempt_count invariant check |
| Date | 2015-09-29 12:40 +0200 |
| Message-ID | <qe0ud-3SL-17@gated-at.bofh.it> (permalink) |
| References | <qdZHQ-2IS-3@gated-at.bofh.it> <qe0ud-3SL-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Sep 29, 2015 at 12:27:55PM +0200, Peter Zijlstra wrote: > > Ingo requested I keep my debug check for the preempt_count invariant. > > Requested-by: Ingo Molnar <mingo@kernel.org> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > kernel/sched/core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -2503,6 +2503,11 @@ static struct rq *finish_task_switch(str > struct mm_struct *mm = rq->prev_mm; > long prev_state; > > + if (unlikely(WARN_ONCE(preempt_count() != 2, That should have: s/2/2*PREEMPT_DISABLE_OFFSET/ or something, otherwise !PREEMPT_COUNT kernels will go funny. > + "corrupted preempt_count: %s/%d/0x%x\n", > + current->comm, current->pid, preempt_count()))) > + preempt_count_set(INIT_PREEMPT_COUNT); > + > rq->prev_mm = NULL; > > /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH 00/11] sched: Killing PREEMPT_ACTIVE Peter Zijlstra <peterz@infradead.org> - 2015-09-29 11:50 +0200
[RFC][PATCH 12/11] sched: Add preempt_count invariant check Peter Zijlstra <peterz@infradead.org> - 2015-09-29 12:40 +0200
Re: [RFC][PATCH 12/11] sched: Add preempt_count invariant check Peter Zijlstra <peterz@infradead.org> - 2015-09-29 12:40 +0200
[RFC][PATCH v2 12/11] sched: Add preempt_count invariant check Peter Zijlstra <peterz@infradead.org> - 2015-09-29 13:10 +0200
Re: [RFC][PATCH v2 12/11] sched: Add preempt_count invariant check Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-29 14:00 +0200
Re: [RFC][PATCH v2 12/11] sched: Add preempt_count invariant check Peter Zijlstra <peterz@infradead.org> - 2015-09-29 14:10 +0200
Re: [RFC][PATCH 00/11] sched: Killing PREEMPT_ACTIVE Ingo Molnar <mingo@kernel.org> - 2015-09-29 12:40 +0200
csiph-web