Re: [PATCH 1/2] nios2: Add architectural support for PCIe

From	Ley Foon Tan <lftan@altera.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] nios2: Add architectural support for PCIe
Date	2015-09-29 12:10 +0200
Message-ID	<qe01b-3kz-11@gated-at.bofh.it> (permalink)
References	<qbqXU-89s-5@gated-at.bofh.it> <qbuf8-4hk-17@gated-at.bofh.it> <qdTCq-2zg-11@gated-at.bofh.it> <qdXG1-8il-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 29, 2015 at 3:37 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 29 September 2015 11:12:24 Ley Foon Tan wrote:
>> >
>> > I think that would be good, yes. We probably picked defaults for the
>> > asm-generic version that are enough to build with CONFIG_PCI disabled,
>> > but there are useful defaults for the other case as well.
>> >
>> > Most architectures that use the file don't support PCI, so you can just
>> > add stuff inside of #ifdef CONFIG_PCI. For the remaining 13 architectures
>> > (git grep -l generic/pci.h  | wc), see whether there are conflicts first.
>> > The normal way would be to have the arch specific definition come before
>> > the #include, and then do something like
>> >
>> > #ifndef pci_proc_domain
>> > #define pci_proc_domain pci_proc_domain
>> > static inline int pci_proc_domain(struct pci_bus *bus)
>> > {
>> > #ifdef CONFIG_PCI_DOMAINS_GENERIC
>> >         return pci_domain_nr(bus);
>> > #else
>> >         return 1;
>> > }
>> > #endif
>>
>> Okay, will try add them to asm-generic.
>
> Thanks
>
>> Do you prefer to send it as separate patch or can be part of this patchset?
>
> I prefer the patches to be part of this series and merged through together
> with them.
>
Okay, will send a new version later.

Thanks.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] nios2: Add architectural support for PCIe Ley Foon Tan <lftan@altera.com> - 2015-09-22 13:00 +0200
  Re: [PATCH 1/2] nios2: Add architectural support for PCIe Arnd Bergmann <arnd@arndb.de> - 2015-09-22 13:50 +0200
    Re: [PATCH 1/2] nios2: Add architectural support for PCIe Ley Foon Tan <lftan@altera.com> - 2015-09-29 05:20 +0200
      Re: [PATCH 1/2] nios2: Add architectural support for PCIe Arnd Bergmann <arnd@arndb.de> - 2015-09-29 09:40 +0200
        Re: [PATCH 1/2] nios2: Add architectural support for PCIe Ley Foon Tan <lftan@altera.com> - 2015-09-29 12:10 +0200

csiph-web