Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults

From	Dave Hansen <dave@sr71.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults
Date	2015-09-28 00:50 +0200
Message-ID	<qdsVz-419-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <qcbaq-7wh-11@gated-at.bofh.it> <qciOC-1BH-15@gated-at.bofh.it> <qcvst-2R9-7@gated-at.bofh.it> <qcKrv-7uN-3@gated-at.bofh.it> <qcR9D-d5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/25/2015 11:20 PM, Ingo Molnar wrote:
> * Dave Hansen <dave@sr71.net> wrote:
...
>> Since follow_pte() fails for all huge
>> pages, it just falls back to pulling the protection key out of the VMA,
>> which _does_ work for huge pages.
> 
> That might be true for explicit hugetlb vmas, but what about transparent hugepages 
> that can show up in regular vmas?

All PTEs (large or small) established under a given VMA have the same
protection key.  Any change in protection key for a range will either
change or split the VMA.

So I think it's safe to rely on the VMA entirely.  Well, as least as
safe as the PTE.  It's definitely a wee bit racy, which I'll elaborate
on when I repost the patches.

>> I've actually removed the PTE walking and I just now use the VMA directly.  I 
>> don't see a ton of additional value from walking the page tables when we can get 
>> what we need from the VMA.
> 
> That's actually good, because it's also cheap, especially if we can get rid of the 
> extra find_vma().
> 
> and we (thankfully) have no non-linear vmas to worry about anymore.

Yep.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Ingo Molnar <mingo@kernel.org> - 2015-09-24 11:30 +0200
  Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Ingo Molnar <mingo@kernel.org> - 2015-09-24 11:40 +0200
    Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Dave Hansen <dave@sr71.net> - 2015-09-24 19:50 +0200
      Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Ingo Molnar <mingo@kernel.org> - 2015-09-25 09:20 +0200
        Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Dave Hansen <dave@sr71.net> - 2015-09-26 01:20 +0200
          Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Ingo Molnar <mingo@kernel.org> - 2015-09-26 08:30 +0200
            Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Dave Hansen <dave@sr71.net> - 2015-09-28 00:50 +0200
              Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Ingo Molnar <mingo@kernel.org> - 2015-09-28 08:00 +0200
  Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Dave Hansen <dave@sr71.net> - 2015-09-24 19:20 +0200
    Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Christian Borntraeger <borntraeger@de.ibm.com> - 2015-09-28 21:30 +0200
      Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key  faults Dave Hansen <dave@sr71.net> - 2015-09-28 21:40 +0200

csiph-web