Re: [PATCH v2 4/4] perf tools: Enable event_config terms to tracepoint events

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] perf tools: Enable event_config terms to tracepoint events
Date	2015-09-27 22:50 +0200
Message-ID	<qdr3s-1jj-7@gated-at.bofh.it> (permalink)
References	<qczcJ-88V-5@gated-at.bofh.it> <qczcL-88V-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 25, 2015 at 11:11:51AM +0000, He Kuang wrote:

SNIP

>  
> +static int config_term_tracepoint(struct perf_event_attr *attr,
> +				  struct parse_events_term *term,
> +				  struct parse_events_error *err)
> +{
> +	switch (term->type_term) {
> +	case PARSE_EVENTS__TERM_TYPE_CALLGRAPH:
> +	case PARSE_EVENTS__TERM_TYPE_STACKSIZE:
> +		return config_term_common(attr, term, err);
> +	default:
> +		if (err) {
> +			err->idx = term->err_term;
> +			err->str = strdup("unknown term");
> +			err->help = strdup(
> +				"valid terms: call-graph,stack-size\n");

please keep that on one line, we dont follow 80 chars rule strictly
if it results in ugly formatting like above

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/4] perf tools: Adds the config_term callback for different type events He Kuang <hekuang@huawei.com> - 2015-09-25 13:20 +0200
  [PATCH v2 2/4] perf tools: Prompt error message for wrong terms of hw/sw events He Kuang <hekuang@huawei.com> - 2015-09-25 13:20 +0200
    Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms  of hw/sw events Jiri Olsa <jolsa@redhat.com> - 2015-09-27 22:30 +0200
    Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms  of hw/sw events Jiri Olsa <jolsa@redhat.com> - 2015-09-27 22:30 +0200
    Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms  of hw/sw events Jiri Olsa <jolsa@redhat.com> - 2015-09-27 22:40 +0200
  [PATCH v2 4/4] perf tools: Enable event_config terms to tracepoint events He Kuang <hekuang@huawei.com> - 2015-09-25 13:20 +0200
    Re: [PATCH v2 4/4] perf tools: Enable event_config terms to  tracepoint events Jiri Olsa <jolsa@redhat.com> - 2015-09-27 22:50 +0200

csiph-web