Re: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent"

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent"
Date	2015-09-27 15:10 +0200
Message-ID	<qdjSh-82P-5@gated-at.bofh.it> (permalink)
References	<qbA1d-46k-29@gated-at.bofh.it> <qbADV-561-59@gated-at.bofh.it> <qbTnc-6Xk-17@gated-at.bofh.it> <qdhx8-4wG-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello.

On 9/27/2015 1:29 PM, Thomas Gleixner wrote:

>>> -	d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI);
>>> -	if (!d)
>>> -		d = irq_find_host(msi_np);
>>> -	dev_set_msi_domain(dev, d);
>>> +		d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI);
>>> +		if (!d)
>>
>> 		if (!d) {
>>
>>> +			d = irq_find_host(args.np);
>>> +
>>> +		if (d) {
>>
>> 		} else {
>>
>>> +			dev_set_msi_domain(dev, d);
>>> +			return;
>>> +		}
>
> Errm, no. How is that equivalent?
>
> Marc:
>
>        d = foo();
>        if (!d)
>        	 d = bar();
>        if (d) {
>           bla(d);
> 	 return;
>        }
>
> Yours:
>
>        d = foo();
>        if (!d) {
>        	 d = bar();
>        } else {
>           bla(d);
> 	 return;
>        }
>
> Hmm?

    Ah, sorry, didn't notice the kind of assignment in the first branch. :-<

> Thanks,
> 	tglx

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] of: Handle multi-parent version of msi-parent Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:00 +0200
  [PATCH 4/4] irqchip/gic-v3-its: Parse new version of msi-parent property Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:40 +0200
  [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper function Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:40 +0200
    Re: [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper function Rob Herring <robh@kernel.org> - 2015-09-29 19:30 +0200
      Re: [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper function Marc Zyngier <marc.zyngier@arm.com> - 2015-09-30 11:10 +0200
      Re: [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper  function Mark Rutland <mark.rutland@arm.com> - 2015-09-30 16:00 +0200
    Re: [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper  function Robin Murphy <robin.murphy@arm.com> - 2015-09-30 17:40 +0200
      Re: [PATCH 1/4] of: Add of_parse_phandle_with_opt_args() helper function Marc Zyngier <marc.zyngier@arm.com> - 2015-09-30 19:20 +0200
  [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent" Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:40 +0200
    Re: [PATCH 2/4] of: irq: Add support for the new definition of  "msi-parent" Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-23 16:40 +0200
      Re: [PATCH 2/4] of: irq: Add support for the new definition of  "msi-parent" Thomas Gleixner <tglx@linutronix.de> - 2015-09-27 12:40 +0200
        Re: [PATCH 2/4] of: irq: Add support for the new definition of  "msi-parent" Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-27 15:10 +0200

csiph-web