Re: [PATCH v2 12/12] media: flash: use led_set_brightness_sync for torch brightness

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 12/12] media: flash: use led_set_brightness_sync for torch brightness
Date	2015-09-29 11:40 +0200
Message-ID	<qdZya-2xz-7@gated-at.bofh.it> (permalink)
References	<qdGlP-6Bl-3@gated-at.bofh.it> <qdGlQ-6Bl-23@gated-at.bofh.it> <qdNnk-1Sz-19@gated-at.bofh.it> <qdXwl-878-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 2015-09-29 09:26:27, Jacek Anaszewski wrote:
> Hi Pavel,
> 
> Thanks for the review.
> 
> On 09/28/2015 10:37 PM, Pavel Machek wrote:
> >On Mon 2015-09-28 15:07:21, Jacek Anaszewski wrote:
> >>LED subsystem shifted responsibility for choosing between SYNC or ASYNC
> >>way of setting brightness from drivers to the caller. Adapt the wrapper
> >>to those changes.
> >
> >Umm. Maybe right patch, but wrong position in the queue, no?
> >
> >If I understand changelog correctly, LED flashes will be subtly broken
> >before this patch is applied.
> >
> >I guess this patch should be moved sooner so everything works at each
> >position in bisect...?
> 
> Moving it wouldn't improve anything. It would have to be merged with
> patch 7/12 [1]. However, as you mentioned, LED flashes before this
> patch will be broken only subtly, i.e. torch brightness will be set
> from a work queue task and not synchronously. It would be barely
> noticeable. Nonetheless, I can merge the patches in the next
> version of the patch set.

Ok, flash firing a tiny bit later is probably not huge problem. I
guess it is best to leave the patches as is.

Best regards,
								Pavel


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 12/12] media: flash: use led_set_brightness_sync for torch  brightness Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-28 15:10 +0200
  Re: [PATCH v2 12/12] media: flash: use led_set_brightness_sync for  torch brightness Pavel Machek <pavel@ucw.cz> - 2015-09-28 22:40 +0200
    Re: [PATCH v2 12/12] media: flash: use led_set_brightness_sync for  torch brightness Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-09-29 09:30 +0200
      Re: [PATCH v2 12/12] media: flash: use led_set_brightness_sync for  torch brightness Pavel Machek <pavel@ucw.cz> - 2015-09-29 11:40 +0200

csiph-web