Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234783

Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs.

Show all headers | View raw

On Monday 28 September 2015 17:56:24 David Daney wrote:
> From: David Daney <david.daney@cavium.com>
> 
> Early versions of the Cavium Thunder CN88XX processor are missing
> Enhanced Allocation (EA) capabilities for the fixed BAR addresses used
> by the on-SoC hardware blocks.
> 
> Add config access functions that synthesize the missing EA
> capabilities for versions that are missing that information.  Since
> this is a little hacky, gate the inclusion of the code with a new
> Kconfig variable.
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> 
> As suggested by Bjorn Helgaas...  It is RFC at this point, but this is
> working well for me.

I don't have an opinion on the way you implement the config space
accessors, but it seems that the overall amount of code is comparable
to the normal pci-host-generic driver without this, and it is not
really generic at all.

I think because of this, it makes more sense to have a separate top-level
driver for this and not reuse the pci-host-generic implementation here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs. David Daney <ddaney.cavm@gmail.com> - 2015-09-29 03:00 +0200
  Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs. Arnd Bergmann <arnd@arndb.de> - 2015-09-29 09:50 +0200

csiph-web