Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234636
| From | "Wu, Songjun" <songjun.wu@atmel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings |
| Date | 2015-09-29 03:50 +0200 |
| Message-ID | <qdSdk-kl-15@gated-at.bofh.it> (permalink) |
| References | <qdCLf-1sd-5@gated-at.bofh.it> <qdCLf-1sd-3@gated-at.bofh.it> <qdEN4-4h4-3@gated-at.bofh.it> |
| Organization | ATMEL |
On 9/28/2015 19:26, Peter Korsgaard wrote:
>>>>>> "kbuild" == kbuild test robot <lkp@intel.com> writes:
>
> > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
> > PTR_ERR should access the value just tested by IS_ERR
>
> > Semantic patch information:
> > There can be false positives in the patch case, where it is the call
> > IS_ERR that is wrong.
>
> > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> > CC: Songjun Wu <songjun.wu@atmel.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
>
> > atmel-classd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > --- a/sound/soc/atmel/atmel-classd.c
> > +++ b/sound/soc/atmel/atmel-classd.c
> > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
>
> dd-> gclk = devm_clk_get(dev, "gclk");
> > if (IS_ERR(dd->aclk)) {
> > - ret = PTR_ERR(dd->gclk);
> > + ret = PTR_ERR(dd->aclk);
>
> It looks like it is the other way around. It should test
> IS_ERR(dd->gclk) instead.
>
Thank you, you are right.
It should test IS_ERR(dd->gclk) instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND PATCH v2 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu <songjun.wu@atmel.com> - 2015-09-28 07:20 +0200
[PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings kbuild test robot <lkp@intel.com> - 2015-09-28 11:20 +0200
Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings Peter Korsgaard <peter@korsgaard.com> - 2015-09-28 13:30 +0200
Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings "Wu, Songjun" <songjun.wu@atmel.com> - 2015-09-29 03:50 +0200
[PATCH] ASoC: atmel-classd: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-09-28 11:20 +0200
csiph-web