Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding
Date	2015-09-28 21:40 +0200
Message-ID	<qdMrf-sh-7@gated-at.bofh.it> (permalink)
References	<qbAug-4UA-57@gated-at.bofh.it> <qdzu2-52B-15@gated-at.bofh.it> <qdKz7-6dR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 28 September 2015 12:31:36 Rob Herring wrote:
> >> > +
> >> > +Required properties:
> >> > +- compatible :       should contain "altr,pcie-root-port-1.0"
> >> > +- reg:               a list of physical base address and length for TXS and CRA.
> >> > +- reg-names: must include the following entries:
> >> > +             "Txs" or "txs": TX slave port region
> >> > +             "Cra" or "cra": Control register access region
> >>
> >> Why both cases? Can we please just have one (or none is better IMO).
> > The PCIe IP on different device families use different register names.
> > And our device tree generator will auto generate the register names
> > based on the hardware description name. Too bad we can't change the
> > hardware description names now.
> 
> Okay, your problem to maintain. Hopefully the driver just goes by index then.
> 
> Strictly speaking, if you have undocumented bindings downstream that
> is your problem and we don't have to accept them as-is upstream. I'm
> not going to worry about that here.

Are they always in the same order? If you don't mandate any names for the
registers in the binding but just use them by index, we can keep that
bit of ugliness out of the binding and the driver and still be compatible
with all the devices.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Rob Herring <robh@kernel.org> - 2015-09-26 20:20 +0200
  Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Ley Foon Tan <lftan@altera.com> - 2015-09-28 07:50 +0200
    Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Rob Herring <robh@kernel.org> - 2015-09-28 19:40 +0200
      Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding Arnd Bergmann <arnd@arndb.de> - 2015-09-28 21:40 +0200
        Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Ley Foon Tan <lftan@altera.com> - 2015-10-02 10:00 +0200
      Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Ley Foon Tan <lftan@altera.com> - 2015-10-02 10:00 +0200
        Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie device tree binding Arnd Bergmann <arnd@arndb.de> - 2015-10-03 00:00 +0200
          Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Marc Zyngier <marc.zyngier@arm.com> - 2015-10-03 15:20 +0200
          Re: [PATCH v7 5/6] Documentation: dt-bindings: pci: altera pcie  device tree binding Ley Foon Tan <lftan@altera.com> - 2015-10-05 05:20 +0200

csiph-web