Re: [PATCH 1/1] net sysfs: Print link speed as signed integer

From	Florian Westphal <fw@strlen.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net sysfs: Print link speed as signed integer
Date	2015-09-28 15:10 +0200
Message-ID	<qdGlR-6Bl-45@gated-at.bofh.it> (permalink)
References	<qdG2u-5Zh-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Alexander Stein <alexander.stein@systec-electronic.com> wrote:
> Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
> Documentation/ABI/testing/sysfs-class-net does not state if this shall be
> signed or unsigned.
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index 805a95a..e3f7eea 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -31,7 +31,7 @@
>  static const char fmt_hex[] = "%#x\n";
>  static const char fmt_long_hex[] = "%#lx\n";
>  static const char fmt_dec[] = "%d\n";
> -static const char fmt_udec[] = "%u\n";
> +static const char fmt_udec[] = "%d\n";
>  static const char fmt_ulong[] = "%lu\n";
>  static const char fmt_u64[] = "%llu\n";

That looks bogus.  If this is about 'speed' attribute
consider removing fmt_udec and replace the printf specifier
of speed_show with fmt_dec instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net sysfs: Print link speed as signed integer Alexander Stein <alexander.stein@systec-electronic.com> - 2015-09-28 14:50 +0200
  Re: [PATCH 1/1] net sysfs: Print link speed as signed integer Florian Westphal <fw@strlen.de> - 2015-09-28 15:10 +0200

csiph-web