Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234098

Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes

Show all headers | View raw

This one makes me slightly nervous, because it isn't clear that these aren't potentially performance sensitive.

On September 28, 2015 5:23:57 AM PDT, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>This function compiles to 277 bytes of machine code and has 4
>callsites.
>
>Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>CC: Ingo Molnar <mingo@kernel.org>
>CC: Andy Lutomirski <luto@amacapital.net>
>CC: "H. Peter Anvin" <hpa@zytor.com>
>CC: Borislav Petkov <bp@alien8.de>
>CC: Brian Gerst <brgerst@gmail.com>
>CC: x86@kernel.org
>CC: linux-kernel@vger.kernel.org
>---
> arch/x86/kernel/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
>index da52e6b..054a4d0 100644
>--- a/arch/x86/kernel/signal.c
>+++ b/arch/x86/kernel/signal.c
>@@ -196,7 +196,7 @@ static unsigned long align_sigframe(unsigned long
>sp)
> 	return sp;
> }
> 
>-static inline void __user *
>+static void __user *
>get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t
>frame_size,
> 	     void __user **fpstate)
> {

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/apic: Deinline __x2apic_disable, save 467 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-28 14:30 +0200
  [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-28 14:30 +0200
    Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes "H. Peter Anvin" <hpa@zytor.com> - 2015-09-28 14:40 +0200
      Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-28 15:50 +0200
        Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes Davidlohr Bueso <dave@stgolabs.net> - 2015-09-28 22:30 +0200
          Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes Thomas Gleixner <tglx@linutronix.de> - 2015-09-29 21:00 +0200
    [tip:x86/cleanups] x86/signal: Deinline get_sigframe,   save 240 bytes tip-bot for Denys Vlasenko <tipbot@zytor.com> - 2015-09-30 22:00 +0200
  [PATCH] x86: Deinline e820_type_to_string, save 126 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-28 14:30 +0200
    [tip:x86/cleanups] x86/e820: Deinline e820_type_to_string,   save 126 bytes tip-bot for Denys Vlasenko <tipbot@zytor.com> - 2015-09-30 22:00 +0200
  [PATCH] x86: Deinline early_console_register, save 403 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-28 14:30 +0200
    [tip:x86/cleanups] x86: Deinline early_console_register,   save 403 bytes tip-bot for Denys Vlasenko <tipbot@zytor.com> - 2015-09-30 22:00 +0200

csiph-web