Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234061

Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer

Show all headers | View raw

On Mon, 28 Sep 2015 07:02:52 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> wrote:

> Add hook for UBI bakvol in ubifs layer.
> 
> open/close bakvol operation in ubifs mount.
> 
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
>  fs/ubifs/super.c | 6 ++++++
>  fs/ubifs/ubifs.h | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 9547a278..f3bf548 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1463,6 +1463,8 @@ static int mount_ubifs(struct ubifs_info *c)
>  	dbg_gen("max. seq. number:    %llu", c->max_sqnum);
>  	dbg_gen("commit number:       %llu", c->cmt_no);
>  
> +	init_bakvol(c->ubi, 1);

This function is implemented in patch 9 and you're using it here, which
means your series is not bisectable.

Also, do we really want to let UBIFS decide whether this feature should
be enabled or not for the whole UBI device?

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer Bean Huo 霍斌斌 (beanhuo)   <beanhuo@micron.com> - 2015-09-28 09:10 +0200
  Re: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-28 13:30 +0200

csiph-web