Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine
Date	2015-09-28 10:00 +0200
Message-ID	<qdBvQ-7TG-7@gated-at.bofh.it> (permalink)
References	<q5I1s-8fg-11@gated-at.bofh.it> <qdukG-67P-7@gated-at.bofh.it> <qduXn-6Qt-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Brian Norris <computersforpeace@gmail.com> writes:

> On Sun, Sep 27, 2015 at 05:18:56PM -0700, Brian Norris wrote:
>> Sparse has one complaint, but I have no others:
>> 
>> On Sun, Sep 06, 2015 at 03:12:47PM +0200, Robert Jarzmik wrote:
>> > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
>> > index 2f39bfe34584..1e9d462065e8 100644
>> > --- a/drivers/mtd/nand/pxa3xx_nand.c
>> > +++ b/drivers/mtd/nand/pxa3xx_nand.c
>> > @@ -15,7 +15,9 @@
>> ...
>> > @@ -564,57 +567,61 @@ static void handle_data_pio(struct pxa3xx_nand_info *info)
>> [...]
>> > +static void start_data_dma(struct pxa3xx_nand_info *info)
>> > +{
>> > +	enum dma_data_direction direction;
>> 
>> I think this should be dma_transfer_direction. See warning below.
>
> I just fixed this up and pushed to l2-mtd.git. I can revert and apply
> something different if you'd like.
Thanks, your fix is perfectly correct.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine Brian Norris <computersforpeace@gmail.com> - 2015-09-28 02:20 +0200
  Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine Brian Norris <computersforpeace@gmail.com> - 2015-09-28 03:00 +0200
    Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-28 10:00 +0200

csiph-web