Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap
Date	2015-09-28 09:20 +0200
Message-ID	<qdAT7-7af-1@gated-at.bofh.it> (permalink)
References	<qcX5o-dn-13@gated-at.bofh.it> <qcX5o-dn-11@gated-at.bofh.it> <qdmQ9-3Ov-3@gated-at.bofh.it> <qdooW-5T3-3@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote:
> On 09/27/2015 06:10 PM, Jean Delvare wrote:
> > Looks good, however I think you should #include <linux/bitmap.h> to
> > avoid build failures in the future or on certain architectures.
> 
> <linux/cpumask.h> already includes <linux/bitmap.h>
> on any arch.

Today it does. Tomorrow, who knows.

> p4-clockmod.c builds only on x86 arch, it's Pentium 4
> on demand clock modulation/speed scaling module.

That is a valid point. My comment was generic, I did not pay attention
to the specific driver.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-26 14:50 +0200
  Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS]  with bitmap Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-27 00:10 +0200
  Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS]  with bitmap Jean Delvare <jdelvare@suse.de> - 2015-09-27 18:20 +0200
    Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS]  with bitmap Denys Vlasenko <dvlasenk@redhat.com> - 2015-09-27 20:00 +0200
      Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS]  with bitmap Jean Delvare <jdelvare@suse.de> - 2015-09-28 09:20 +0200

csiph-web