Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Date	2015-09-26 19:30 +0200
Message-ID	<qd1sl-6zC-7@gated-at.bofh.it> (permalink)
References	<qbzya-3xX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Valentin,

On Tue, Sep 22, 2015 at 07:28:23PM +0200, Valentin Rothberg wrote:
> From bceb7cace76aba9212db56be939bfecaacb75bc2 Mon Sep 17 00:00:00 2001
> From: Valentin Rothberg <valentinrothberg@gmail.com>
> Date: Tue, 22 Sep 2015 19:00:40 +0200
> Subject: [PATCH] wm831x_power: Use IRQF_ONESHOT to request threaded IRQs
> 
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
> 
> scripts/coccinelle/misc/irqf_oneshot.cocci detected this issue.
> 
> Fixes: b5874f33bbaf ("wm831x_power: Use genirq")
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>

Thanks, queued.

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with  no primary handler requested without IRQF_ONESHOT Valentin Rothberg <valentinrothberg@gmail.com> - 2015-09-22 19:30 +0200
  Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with  no primary handler requested without IRQF_ONESHOT Sasha Levin <sasha.levin@oracle.com> - 2015-09-22 21:50 +0200
    Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with  no primary handler requested without IRQF_ONESHOT Valentin Rothberg <valentinrothberg@gmail.com> - 2015-09-22 22:10 +0200
      Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with  no primary handler requested without IRQF_ONESHOT Sebastian Reichel <sre@kernel.org> - 2015-09-26 19:00 +0200
  Re: drivers/power/wm831x_power.c:569:7-27: ERROR: Threaded IRQ with  no primary handler requested without IRQF_ONESHOT Sebastian Reichel <sre@kernel.org> - 2015-09-26 19:30 +0200

csiph-web