Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232708

Re: [PATCH v2 2/2] btrfs: reada: Fix returned errno code

Show all headers | View raw

On Thu, Sep 24, 2015 at 08:13:33PM +0100, Luis de Bethencourt wrote:
> reada is using -1 instead of the -ENOMEM defined macro to specify that
> a buffer allocation failed. Since the error number is propagated, the
> caller will get a -EPERM which is the wrong error condition.
> 
> Also, updating the caller to return the exact value from
> reada_add_block.
> 
> Smatch tool warning:
> reada_add_block() warn: returning -1 instead of -ENOMEM is sloppy
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Reviewed-by: David Sterba <dsterba@suse.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] btrfs: Fix returned errno codes Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-24 21:20 +0200
  [PATCH v2 2/2] btrfs: reada: Fix returned errno code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-24 21:20 +0200
    Re: [PATCH v2 2/2] btrfs: reada: Fix returned errno code David Sterba <dsterba@suse.cz> - 2015-09-25 12:50 +0200
  [PATCH v2 1/2] btrfs: check-integrity: Fix returned errno codes Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-24 21:20 +0200

csiph-web