[PATCH v4] mfd: tps6105x: Fix possible NULL pointer access.

From	Grigoryev Denis <grigoryev@fastwel.ru>
Newsgroups	linux.kernel
Subject	[PATCH v4] mfd: tps6105x: Fix possible NULL pointer access.
Date	2015-09-25 11:50 +0200
Message-ID	<qcxND-60U-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

dHBzNjEwNXggZHJpdmVyIHByb3ZpZGVzIHR3byBjZWxscy4gT25lIGlzIGZvciBHUElPIGFuZCBh
bm90aGVyIG9uZSBpcwpmb3Igc2VsZWN0ZWQgbW9kZSBkZXBlbmRpbmcgb24gcGxhdGZvcm0gZGF0
YS4gV2hlbiB0cHM2MTA1eCBpcyB1c2VkIGluCkdQSU8tb25seSBtb2RlLCB0aGlzIGRyaXZlciBj
YWxscyBtZmRfYWRkX2RldmljZXMoKSB3aXRoIG1mZF9jZWxsCi5uYW1lID09IE5VTEwuIFRoaXMg
dmFsdWUgY2F1c2VzIGFuIG9vcHMgaW4gcGxhdGZvcm1fZGV2aWNlX3JlZ2lzdGVyKCkKbGF0ZXIu
CgpUaGUgZm9sbG93aW5nIHBhdGNoIGFkZHMgYSBtZmRfY2VsbCBmb3IgZWFjaCBwb3NzaWJsZSBt
b2RlIHRoZXJlYnkKZXhjbHVkaW5nIC5uYW1lIGFzc2lnbm1lbnQgaW4gcnVudGltZS4KClNpZ25l
ZC1vZmYtYnk6IERlbmlzIEdyaWdvcnlldiA8Z3JpZ29yeWV2QGZhc3R3ZWwucnU+Ci0tLQogZHJp
dmVycy9tZmQvdHBzNjEwNXguYyB8ICAgNzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst
LS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgMjkg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZmQvdHBzNjEwNXguYyBiL2RyaXZl
cnMvbWZkL3RwczYxMDV4LmMKaW5kZXggNWRlOTVjMi4uZjM0ZjE5ZCAxMDA2NDQKLS0tIGEvZHJp
dmVycy9tZmQvdHBzNjEwNXguYworKysgYi9kcml2ZXJzL21mZC90cHM2MTA1eC5jCkBAIC0xMTks
MjcgKzExOSw0NyBAQCBzdGF0aWMgaW50IHRwczYxMDV4X3N0YXJ0dXAoc3RydWN0IHRwczYxMDV4
ICp0cHM2MTA1eCkKIH0KIAogLyoKLSAqIE1GRCBjZWxscyAtIHdlIGhhdmUgb25lIGNlbGwgd2hp
Y2ggaXMgc2VsZWN0ZWQgb3BlcmF0aW9uCi0gKiBtb2RlLCBhbmQgd2UgYWx3YXlzIGhhdmUgYSBH
UElPIGNlbGwuCisgKiBNRkQgY2VsbHMgLSB3ZSBhbHdheXMgaGF2ZSBhIEdQSU8gY2VsbCBhbmQg
d2UgaGF2ZSBvbmUgY2VsbAorICogd2hpY2ggaXMgc2VsZWN0ZWQgb3BlcmF0aW9uIG1vZGUuCiAg
Ki8KLXN0YXRpYyBzdHJ1Y3QgbWZkX2NlbGwgdHBzNjEwNXhfY2VsbHNbXSA9IHsKLQl7Ci0JCS8q
IG5hbWUgd2lsbCBiZSBydW50aW1lIGFzc2lnbmVkICovCi0JCS5pZCA9IC0xLAotCX0sCi0Jewot
CQkubmFtZSA9ICJ0cHM2MTA1eC1ncGlvIiwKLQkJLmlkID0gLTEsCi0JfSwKK3N0YXRpYyBzdHJ1
Y3QgbWZkX2NlbGwgdHBzNjEwNXhfZGV2X2dwaW8gPSB7CisJLm5hbWUgPSAidHBzNjEwNXgtZ3Bp
byIsCit9OworCitzdGF0aWMgc3RydWN0IG1mZF9jZWxsIHRwczYxMDV4X2Rldl9sZWRzID0gewor
CS5uYW1lID0gInRwczYxMDV4LWxlZHMiLAorfTsKKworc3RhdGljIHN0cnVjdCBtZmRfY2VsbCB0
cHM2MTA1eF9kZXZfZmxhc2ggPSB7CisJLm5hbWUgPSAidHBzNjEwNXgtZmxhc2giLAogfTsKIAor
c3RhdGljIHN0cnVjdCBtZmRfY2VsbCB0cHM2MTA1eF9kZXZfcmVndWxhdG9yID0geworCS5uYW1l
ID0gInRwczYxMDV4LXJlZ3VsYXRvciIsCit9OworCitzdGF0aWMgaW50IHRwczYxMDV4X2FkZF9k
ZXZpY2Uoc3RydWN0IHRwczYxMDV4ICp0cHM2MTA1eCwKKwkJCSAgICAgICBzdHJ1Y3QgbWZkX2Nl
bGwgKmNlbGwpCit7CisJY2VsbC0+cGxhdGZvcm1fZGF0YSA9IHRwczYxMDV4OworCWNlbGwtPnBk
YXRhX3NpemUgPSBzaXplb2YoKnRwczYxMDV4KTsKKworCXJldHVybiBtZmRfYWRkX2RldmljZXMo
JnRwczYxMDV4LT5jbGllbnQtPmRldiwKKwkJCSAgICAgICBQTEFURk9STV9ERVZJRF9BVVRPLCBj
ZWxsLCAxLCBOVUxMLCAwLCBOVUxMKTsKK30KKwogc3RhdGljIGludCB0cHM2MTA1eF9wcm9iZShz
dHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAogCQkJY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQg
KmlkKQogewogCXN0cnVjdCB0cHM2MTA1eAkJCSp0cHM2MTA1eDsKIAlzdHJ1Y3QgdHBzNjEwNXhf
cGxhdGZvcm1fZGF0YQkqcGRhdGE7CiAJaW50IHJldDsKLQlpbnQgaTsKKworCXBkYXRhID0gZGV2
X2dldF9wbGF0ZGF0YSgmY2xpZW50LT5kZXYpOworCWlmIChwZGF0YSA9PSBOVUxMKSB7CisJCWRl
dl9lcnIoJmNsaWVudC0+ZGV2LCAibWlzc2luZyBwbGF0Zm9ybSBkYXRhXG4iKTsKKwkJcmV0dXJu
IC1FTk9ERVY7CisJfQogCiAJdHBzNjEwNXggPSBkZXZtX2ttYWxsb2MoJmNsaWVudC0+ZGV2LCBz
aXplb2YoKnRwczYxMDV4KSwgR0ZQX0tFUk5FTCk7CiAJaWYgKCF0cHM2MTA1eCkKQEAgLTE0Nyw3
ICsxNjcsNiBAQCBzdGF0aWMgaW50IHRwczYxMDV4X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpj
bGllbnQsCiAKIAlpMmNfc2V0X2NsaWVudGRhdGEoY2xpZW50LCB0cHM2MTA1eCk7CiAJdHBzNjEw
NXgtPmNsaWVudCA9IGNsaWVudDsKLQlwZGF0YSA9IGRldl9nZXRfcGxhdGRhdGEoJmNsaWVudC0+
ZGV2KTsKIAl0cHM2MTA1eC0+cGRhdGEgPSBwZGF0YTsKIAltdXRleF9pbml0KCZ0cHM2MTA1eC0+
bG9jayk7CiAKQEAgLTE1NywzOCArMTc2LDMzIEBAIHN0YXRpYyBpbnQgdHBzNjEwNXhfcHJvYmUo
c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKIAkJcmV0dXJuIHJldDsKIAl9CiAKLQkvKiBSZW1v
dmUgd2FybmluZyB0ZXh0cyB3aGVuIHlvdSBpbXBsZW1lbnQgbmV3IGNlbGwgZHJpdmVycyAqLwor
CXJldCA9IHRwczYxMDV4X2FkZF9kZXZpY2UodHBzNjEwNXgsICZ0cHM2MTA1eF9kZXZfZ3Bpbyk7
CisJaWYgKHJldCkKKwkJcmV0dXJuIHJldDsKKwogCXN3aXRjaCAocGRhdGEtPm1vZGUpIHsKIAlj
YXNlIFRQUzYxMDVYX01PREVfU0hVVERPV046CiAJCWRldl9pbmZvKCZjbGllbnQtPmRldiwKIAkJ
CSAicHJlc2VudCwgbm90IHVzZWQgZm9yIGFueXRoaW5nLCBvbmx5IEdQSU9cbiIpOwogCQlicmVh
azsKIAljYXNlIFRQUzYxMDVYX01PREVfVE9SQ0g6Ci0JCXRwczYxMDV4X2NlbGxzWzBdLm5hbWUg
PSAidHBzNjEwNXgtbGVkcyI7Ci0JCWRldl93YXJuKCZjbGllbnQtPmRldiwKLQkJCSAidG9yY2gg
bW9kZSBpcyB1bnN1cHBvcnRlZFxuIik7CisJCXJldCA9IHRwczYxMDV4X2FkZF9kZXZpY2UodHBz
NjEwNXgsICZ0cHM2MTA1eF9kZXZfbGVkcyk7CiAJCWJyZWFrOwogCWNhc2UgVFBTNjEwNVhfTU9E
RV9UT1JDSF9GTEFTSDoKLQkJdHBzNjEwNXhfY2VsbHNbMF0ubmFtZSA9ICJ0cHM2MTA1eC1mbGFz
aCI7Ci0JCWRldl93YXJuKCZjbGllbnQtPmRldiwKLQkJCSAiZmxhc2ggbW9kZSBpcyB1bnN1cHBv
cnRlZFxuIik7CisJCXJldCA9IHRwczYxMDV4X2FkZF9kZXZpY2UodHBzNjEwNXgsICZ0cHM2MTA1
eF9kZXZfZmxhc2gpOwogCQlicmVhazsKIAljYXNlIFRQUzYxMDVYX01PREVfVk9MVEFHRToKLQkJ
dHBzNjEwNXhfY2VsbHNbMF0ubmFtZSA9InRwczYxMDV4LXJlZ3VsYXRvciI7CisJCXJldCA9IHRw
czYxMDV4X2FkZF9kZXZpY2UodHBzNjEwNXgsICZ0cHM2MTA1eF9kZXZfcmVndWxhdG9yKTsKIAkJ
YnJlYWs7CiAJZGVmYXVsdDoKKwkJZGV2X3dhcm4oJmNsaWVudC0+ZGV2LCAiaW52YWxpZCBtb2Rl
OiAlZFxuIiwgcGRhdGEtPm1vZGUpOwogCQlicmVhazsKIAl9CiAKLQkvKiBTZXQgdXAgYW5kIHJl
Z2lzdGVyIHRoZSBwbGF0Zm9ybSBkZXZpY2VzLiAqLwotCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9T
SVpFKHRwczYxMDV4X2NlbGxzKTsgaSsrKSB7Ci0JCS8qIE9uZSBzdGF0ZSBob2xkZXIgZm9yIGFs
bCBkcml2ZXJzLCB0aGlzIGlzIHNpbXBsZSAqLwotCQl0cHM2MTA1eF9jZWxsc1tpXS5wbGF0Zm9y
bV9kYXRhID0gdHBzNjEwNXg7Ci0JCXRwczYxMDV4X2NlbGxzW2ldLnBkYXRhX3NpemUgPSBzaXpl
b2YoKnRwczYxMDV4KTsKLQl9CisJaWYgKHJldCkKKwkJbWZkX3JlbW92ZV9kZXZpY2VzKCZjbGll
bnQtPmRldik7CiAKLQlyZXR1cm4gbWZkX2FkZF9kZXZpY2VzKCZjbGllbnQtPmRldiwgMCwgdHBz
NjEwNXhfY2VsbHMsCi0JCQkgICAgICAgQVJSQVlfU0laRSh0cHM2MTA1eF9jZWxscyksIE5VTEws
IDAsIE5VTEwpOworCXJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyBpbnQgdHBzNjEwNXhfcmVtb3Zl
KHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCi0tIAoxLjcuMTAuNAoK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] mfd: tps6105x: Fix possible NULL pointer access. Grigoryev Denis <grigoryev@fastwel.ru> - 2015-09-25 11:50 +0200
  Re: [PATCH v4] mfd: tps6105x: Fix possible NULL pointer access. Lee Jones <lee.jones@linaro.org> - 2015-09-25 18:30 +0200

csiph-web