Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API
Date	2015-09-25 10:00 +0200
Message-ID	<qcw5c-3AI-19@gated-at.bofh.it> (permalink)
References	<q9Wfw-1oJ-7@gated-at.bofh.it> <q9Wpd-1zU-21@gated-at.bofh.it> <qb0qJ-3sD-3@gated-at.bofh.it> <qcu3o-MY-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (09/25/15 14:46), Joonsoo Kim wrote:
[..]
> > >  struct zcomp_strm *zcomp_decompress_begin(struct zcomp *comp)
> > >  {
> > > +	if (comp->tfm_noctx)
> > > +		return NULL;
> > 
> > Hmm,, I understand why returns NULL but it seems to be awkward to use NULL
> > to express meaningful semantic and following functions relies on.
> > If I have a time, I will think over.
> 
> I also think that it's not good thing but I can't think any better
> idea. Please let me know if you have better one.

yeah, me neither.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-09-25 07:50 +0200
  Re: [PATCH v3 9/9] zram: use crypto decompress_noctx API Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-25 10:00 +0200

csiph-web