Re: [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/9] crypto: introduce decompression API that can be called via sharable tfm object
Date	2015-09-25 10:00 +0200
Message-ID	<qcw5b-3AI-3@gated-at.bofh.it> (permalink)
References	<q9Wfw-1oJ-7@gated-at.bofh.it> <q9Wpd-1zU-25@gated-at.bofh.it> <qb2Ce-6Ly-15@gated-at.bofh.it> <qctK2-qx-1@gated-at.bofh.it> <qcw5b-3AI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 25, 2015 at 04:56:10PM +0900, Sergey Senozhatsky wrote:
>
> so you want to go with _noctx() callbacks implementation?
> that CRYPTO_ALG_TFM_MAY_SHARE flag looks quite simple to
> me. or you guys hate it?

I think we should just replace crypto_pcomp with a new interface
that does what you guys want.  The current crypto_compress interface
is simply broken because it stores per-request state in the tfm.
This runs counter to every other crypto type, e.g., hash or aead.

The tfm should only hold shared data, e.g., compression algorithm
parameters but not per-request state.

As the original pcomp author has disappeared I think you could
even drop the partial stuff and just do a straight compression
interface.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/9] crypto: introduce decompression API that can be  called via sharable tfm object Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2015-09-25 07:30 +0200
  Re: [PATCH v3 1/9] crypto: introduce decompression API that can be  called via sharable tfm object Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-09-25 10:00 +0200
    Re: [PATCH v3 1/9] crypto: introduce decompression API that can be  called via sharable tfm object Herbert Xu <herbert@gondor.apana.org.au> - 2015-09-25 10:00 +0200

csiph-web