Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232350

Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module

Show all headers | View raw

Hi Sebastian,

On Tue, Sep 22, 2015 at 11:29 PM, Sebastian Reichel <sre@kernel.org> wrote:
> Hi Marek,
>
> On Tue, Sep 22, 2015 at 10:19:29PM +0200, Marek Belisko wrote:
>> If either twl4030_charger or twl4030_madc is configured as MODULE,
>> we get build (link) errors.
>>
>> To solve, the direct call of twl4030_get_madc_conversion() is replaced
>> by a call to iio_read_channel_processed().
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>> ---
>> changes from V1: added missing iio_channel_release + document and add new DT bindings
>
> That was fast :) Patchset looks fine to me except for one last
> thing: Let's make the iio-channel optional, so that old DT blobs
> are still supported. Also the IS_REACHABLE(CONFIG_TWL4030_MADC)
> check can be removed, it should no longer be needed with
> iio_read_channel_processed().
OK I updated driver code to pass when 'vac' property isn't found in
DT. Should I mark it also
in DT bindings or keep it as it was in v2? Thanks.
>
> -- Sebastian

BR,

marek


-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems when building as module Marek Belisko <marek@goldelico.com> - 2015-09-22 22:30 +0200
  [PATCH v2 3/3] ARM: dts: twl4030: add iio properties for bci subnode Marek Belisko <marek@goldelico.com> - 2015-09-22 22:30 +0200
  Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link  problems when building as module Sebastian Reichel <sre@kernel.org> - 2015-09-22 23:30 +0200
    Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link problems  when building as module Belisko Marek <marek.belisko@gmail.com> - 2015-09-24 21:10 +0200
      Re: [PATCH v2 1/3] drivers: power: twl4030_charger: fix link  problems when building as module Sebastian Reichel <sre@kernel.org> - 2015-09-24 22:40 +0200

csiph-web