Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1232237

Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver
Date Thu, 24 Sep 2015 18:20:03 +0200
Message-ID <qchpx-8a5-35@gated-at.bofh.it> (permalink)
References <qchpw-8a5-19@gated-at.bofh.it>
X-Original-To Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=aqrZ7HI1pz8qj6FmwzNf+wd6MjbmC4zq6Wwi0UgbGqk=; b=N6QkTKWgm4Lx3jnhfzZyj92m5/XqQMbvbEDO6NHtOicLlfNbyiw1wbq/RDDTqj7nSY uKcZnQ9jRBwAbJ4KAVqPoA+r/Fa1J17o3Rib+nZoFWDVsV9E2/3KYOrh3178WexxGcxm aLY1H3N0tmqmjUkDwuE4se3wWH4SyQQasoMjUxTfn/J1qN052XNycD1B5PEqS+g9JxNt 8eldR35j2HJtr2WLUcVCGAgdiL8yW8FUonXjekhccaKLJAO1ASmv0mtf6at080SwzZqI 80AKXlojFtk1K9aj538kc9z9WtaxjFEbY2cElO1ZngH+EZKjOPwkabcIhGwokZkuylMn C9+w==
X-Received by 10.170.55.193 with SMTP id 184mr444147ykx.99.1443111265634; Thu, 24 Sep 2015 09:14:25 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth 9x097aKXhfzYwcwykh01lrmoP5c
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 75
Organization linux.* mail to news gateway
X-Original-Cc Felipe Balbi <balbi@ti.com>, Peter Chen <peter.chen@freescale.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux USB List <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Punnaiah Choudary Kalluri <punnaia@xilinx.com>, Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
X-Original-Date Thu, 24 Sep 2015 11:14:06 -0500
X-Original-Message-ID <CAL_Jsq+=ZafWLj6nScGgVeBOS7qg=h-=Qri43932HdJiSxGExg@mail.gmail.com>
X-Original-References <1443012841-13673-1-git-send-email-sbhatta@xilinx.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1232237

Show key headers only | View raw


On Wed, Sep 23, 2015 at 7:54 AM, Subbaraya Sundeep Bhatta
<subbaraya.sundeep.bhatta@xilinx.com> wrote:
> This patch adds binding doc info for generic ULPI PHYs
> platform driver.
>
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> ---
>  .../devicetree/bindings/usb/ulpi-platform-phy.txt  |   34 ++++++++++++++++++++
>  1 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> new file mode 100644
> index 0000000..7b8cbb4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> @@ -0,0 +1,34 @@
> +Platform driver for generic ULPI PHYs

Platform driver has nothing to do with DT bindings.

> +
> +Required properties:
> +- compatible           : Should be "ulpi-phy"

This needs a more specific compatible in addition.

> +- reg                  : Physical base address and size of the USB
> +                         controller registers map to which this PHY
> +                         is connected.
> +- view-port            : Should contain viewport register offset of the
> +                         USB controller to which this PHY is connected

This is a property of the controller, not the phy.

> +Optional properties:
> +- drv-vbus             : required if turning VBUS on/off has to be driven
> +                         by writing to PHY. This feature depends on board
> +                         design.
> +
> +Example:
> +Below example shows the PHY binding for Chipidea USB controller which has
> +ulpi viewport register at 0x0170
> +
> +               usb_phy0: phy0 {
> +                       compatible = "ulpi-phy";
> +                       reg = <0xe0002000 0x1000>;
> +                       view-port = <0x0170>;
> +                       drv-vbus;
> +               };
> +
> +               usb0: usb@e0002000 {
> +                        compatible = "chipidea,usb2";
> +                        interrupt-parent = <&intc>;
> +                        interrupts = <0 21 4>;
> +                        reg = <0xe0002000 0x1000>;
> +                        phy_type = "ulpi";
> +                       dr_mode = "host";
> +                       usb-phy = <&usb_phy0>;

usb-phy is deprecated. Use phys and the generic phy binding instead.

> +                };
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver Rob Herring <robh@kernel.org> - 2015-09-24 18:20 +0200

csiph-web