Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232037

Re: [PATCH] UBI: Validate data_size

Show all headers | View raw

> On 22.09.2015, at 23:58, Richard Weinberger <richard@nod.at> wrote:
> 
> Make sure that data_size is less than LEB size.
> Otherwise a handcrafted UBI image is able to trigger
> an out of bounds memory access in ubi_compare_lebs().
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/ubi/io.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
> index 5bbd1f0..1fc23e4 100644
> --- a/drivers/mtd/ubi/io.c
> +++ b/drivers/mtd/ubi/io.c
> @@ -926,6 +926,11 @@ static int validate_vid_hdr(const struct ubi_device *ubi,
> 		goto bad;
> 	}
> 
> +	if (data_size > ubi->leb_size) {
> +		ubi_err(ubi, "bad data_size");
> +		goto bad;
> +	}
> +

Nice catch!

Reviewed-by: David Gstir <david@sigma-star.at>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] UBI: Validate data_size Richard Weinberger <richard@nod.at> - 2015-09-23 00:00 +0200
  Re: [PATCH] UBI: Validate data_size David Gstir <david@sigma-star.at> - 2015-09-24 12:40 +0200
    Re: [PATCH] UBI: Validate data_size Richard Weinberger <richard@nod.at> - 2015-09-25 21:50 +0200

csiph-web