Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233115

Re: [PATCH v3 1/4] scsi: remove old-style type names from sg.h

Show all headers | View raw

On 09/25/2015 11:27 AM, Paolo Bonzini wrote:
> These will not be exported by the new linux/sg.h header, and scsi/sg.h will
> not have any user API after linux/sg.h is created.  Since they have no
> user in the kernel, they can be zapped.
> 
> Cc: James Bottomley <jbottomley@parallels.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: linux-scsi@vger.kernel.org
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  include/scsi/sg.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/scsi/sg.h b/include/scsi/sg.h
> index 3afec7032448..370c78c37926 100644
> --- a/include/scsi/sg.h
> +++ b/include/scsi/sg.h
> @@ -207,12 +207,6 @@ typedef struct sg_req_info { /* used by SG_GET_REQUEST_TABLE ioctl() */
>  
>  #define SG_BIG_BUFF SG_DEF_RESERVED_SIZE    /* for backward compatibility */
>  
> -/* Alternate style type names, "..._t" variants preferred */
> -typedef struct sg_io_hdr Sg_io_hdr;
> -typedef struct sg_io_vec Sg_io_vec;
> -typedef struct sg_scsi_id Sg_scsi_id;
> -typedef struct sg_req_info Sg_req_info;
> -
>  
>  /* vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv */
>  /*   The older SG interface based on the 'sg_header' structure follows.   */
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] scsi: cleanup ioctl headers and provide UAPI versions Paolo Bonzini <pbonzini@redhat.com> - 2015-09-25 11:30 +0200
  [PATCH v3 1/4] scsi: remove old-style type names from sg.h Paolo Bonzini <pbonzini@redhat.com> - 2015-09-25 11:30 +0200
    Re: [PATCH v3 1/4] scsi: remove old-style type names from sg.h Hannes Reinecke <hare@suse.de> - 2015-09-26 02:00 +0200
  [PATCH v3 3/4] scsi: move all obsolete ioctls to scsi_ioctl.h Paolo Bonzini <pbonzini@redhat.com> - 2015-09-25 11:30 +0200
  [PATCH v3 2/4] scsi: cleanup scsi/scsi_ioctl.h Paolo Bonzini <pbonzini@redhat.com> - 2015-09-25 11:30 +0200
    Re: [PATCH v3 2/4] scsi: cleanup scsi/scsi_ioctl.h Douglas Gilbert <dgilbert@interlog.com> - 2015-09-28 09:00 +0200
  Re: [PATCH v3 0/4] scsi: cleanup ioctl headers and provide UAPI  versions Christoph Hellwig <hch@lst.de> - 2015-09-25 17:20 +0200

csiph-web