Re: [PATCH 01/19] SUNRPC: fix variable type

From	"J. Bruce Fields" <bfields@fieldses.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/19] SUNRPC: fix variable type
Date	2015-09-25 22:30 +0200
Message-ID	<qcHMZ-3Ev-7@gated-at.bofh.it> (permalink)
References	<qcfnH-5il-3@gated-at.bofh.it> <qcfnH-5il-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ACK.  Assuming Trond gets this.--b.

On Thu, Sep 24, 2015 at 04:00:09PM +0200, Andrzej Hajda wrote:
> Due to incorrect len type bc_send_request returned always zero.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> Hi,
> 
> To avoid problems with too many mail recipients I have sent whole
> patchset only to LKML. Anyway patches have no dependencies.
> 
> Regards
> Andrzej
> ---
>  net/sunrpc/xprtsock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 1a85e0e..60fb002 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2472,7 +2472,7 @@ static int bc_send_request(struct rpc_task *task)
>  {
>  	struct rpc_rqst *req = task->tk_rqstp;
>  	struct svc_xprt	*xprt;
> -	u32                     len;
> +	int len;
>  
>  	dprintk("sending request with xid: %08x\n", ntohl(req->rq_xid));
>  	/*
> -- 
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/19] SUNRPC: fix variable type Andrzej Hajda <a.hajda@samsung.com> - 2015-09-24 16:10 +0200
  Re: [PATCH 01/19] SUNRPC: fix variable type "J. Bruce Fields" <bfields@fieldses.org> - 2015-09-25 22:30 +0200

csiph-web