Re: [RFC v7 25/41] richacl: Isolate the owner and group classes

From	"J. Bruce Fields" <bfields@fieldses.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v7 25/41] richacl: Isolate the owner and group classes
Date	2015-09-25 22:20 +0200
Message-ID	<qcHDj-3sD-1@gated-at.bofh.it> (permalink)
References	<q5iTn-686-5@gated-at.bofh.it> <q5j36-6jH-85@gated-at.bofh.it> <qbB6W-5Uu-39@gated-at.bofh.it> <qbSr8-5Br-9@gated-at.bofh.it> <qczmq-8ke-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 25, 2015 at 01:25:41PM +0200, Andreas Gruenbacher wrote:
> Here is another minor improvement that produces deny aces with fewer
> permissions in them and avoids creating unnecessary deny aces in some
> cases.

Looks good.--b.

> 
> Andreas
> 
> ---
>  fs/richacl_compat.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/richacl_compat.c b/fs/richacl_compat.c
> index 2f53394..bc0bcfe 100644
> --- a/fs/richacl_compat.c
> +++ b/fs/richacl_compat.c
> @@ -605,14 +605,13 @@ __richacl_isolate_who(struct richacl_alloc *alloc, struct richace *who,
>  	int n;
>  
>  	/*
> -	 * Compute the permissions already denied to @who.  There are no
> +	 * Compute the permissions already defined for @who.  There are no
>  	 * everyone@ deny aces left in the acl at this stage.
>  	 */
>  	richacl_for_each_entry(ace, acl) {
>  		if (richace_is_inherit_only(ace))
>  			continue;
> -		if (richace_is_same_identifier(acl, ace, who) &&
> -		    richace_is_deny(ace))
> +		if (richace_is_same_identifier(acl, ace, who))
>  			deny &= ~ace->e_mask;
>  	}
>  	if (!deny)
> -- 
> 2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v7 25/41] richacl: Isolate the owner and group classes bfields@fieldses.org (J. Bruce Fields) - 2015-09-22 21:10 +0200
  Re: [RFC v7 25/41] richacl: Isolate the owner and group classes Andreas Gruenbacher <agruenba@redhat.com> - 2015-09-23 15:40 +0200
    Re: [RFC v7 25/41] richacl: Isolate the owner and group classes Andreas Gruenbacher <agruenba@redhat.com> - 2015-09-25 13:30 +0200
      Re: [RFC v7 25/41] richacl: Isolate the owner and group classes "J. Bruce Fields" <bfields@fieldses.org> - 2015-09-25 22:20 +0200

csiph-web