Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation
Date	Fri, 25 Sep 2015 20:00:02 +0200
Message-ID	<qcFrQ-8B-33@gated-at.bofh.it> (permalink)
References	<qbxmF-sc-9@gated-at.bofh.it> <qbxmF-sc-7@gated-at.bofh.it> <qchSz-gB-19@gated-at.bofh.it> <qck42-3yV-41@gated-at.bofh.it> <qckdJ-3Kz-31@gated-at.bofh.it> <qcl06-4Uy-17@gated-at.bofh.it>
X-Original-To	Toshi Kani <toshi.kani@hpe.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1443203398; bh=ZRKTjo95T4PW8QoT2MPT7cw3fR82YA7LhcJsRwYh2N0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=tTiQvahCiFETmdb0xyBtxbw8jk34p7lXzfQV7p VBOSo1fI1UzoOS0VswPj3Lczw/uvOfaJoIHNOGnwHQtlyBA1KZTNAZPWy0sGxbSHGs/ RVjz3VoX+6CwcOQ/5Vatku4znQy6Y9Fpdo/ptpjEcoQYvX1YIwmEeTqsT4UU9KnG+c=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1443203398; bh=ZRKTjo95T4PW8QoT2MPT7cw3fR82YA7LhcJsRwYh2N0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=tTiQvahCiFETmdb0xyBtxbw8jk34p7lXzfQV7p VBOSo1fI1UzoOS0VswPj3Lczw/uvOfaJoIHNOGnwHQtlyBA1KZTNAZPWy0sGxbSHGs/ RVjz3VoX+6CwcOQ/5Vatku4znQy6Y9Fpdo/ptpjEcoQYvX1YIwmEeTqsT4UU9KnG+c=
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	mchehab@osg.samsung.com, dougthompson@xmission.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, elliott@hpe.com, tony.luck@intel.com
X-Original-Date	Fri, 25 Sep 2015 19:49:56 +0200
X-Original-Message-ID	<20150925174956.GF3568@pd.tnic>
X-Original-References	<1442933883-21587-1-git-send-email-toshi.kani@hpe.com> <1442933883-21587-3-git-send-email-toshi.kani@hpe.com> <20150924164830.GF3774@pd.tnic> <1443121564.25474.160.camel@hpe.com> <20150924191551.GK3774@pd.tnic> <1443124767.25474.172.camel@hpe.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1232988

Show key headers only | View raw

On Thu, Sep 24, 2015 at 01:59:27PM -0600, Toshi Kani wrote:
> On Thu, 2015-09-24 at 21:15 +0200, Borislav Petkov wrote:
> > On Thu, Sep 24, 2015 at 01:06:04PM -0600, Toshi Kani wrote:
> > > edac-utils(1) checks empty labels and shows them as "ch%d" [1].  So,
> > > I think empty labels are supported today, and using 'echo "" >' seems
> > > to be a legitimate way to set them empty if desired.
> > 
> > What would be a sane use case to set a DIMM label to an empty string?
> 
> Well, I guess there isn't a sane use case for it... :-)
> 
> Attached is a patch (on top of patch 2/2) to disallow an empty string.
> I prefer to make it as a separate patch in case someone comes up with
> a valid use-case for it.
> 
> Thanks,
> -Toshi
> 
> ====
> Subject: [PATCH] EDAC: Fail empty string to sysfs dimm_label store
> 
> Updating dimm_label to an empty string does not make much sense.
> Change the sysfs dimm_label store option to fail a request when
> an input string is empty.
> 
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> ---
>  drivers/edac/edac_mc_sysfs.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

All three applied.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Toshi Kani <toshi.kani@hpe.com> - 2015-09-22 17:10 +0200
  Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Borislav Petkov <bp@alien8.de> - 2015-09-24 18:50 +0200
    Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Toshi Kani <toshi.kani@hpe.com> - 2015-09-24 21:10 +0200
      Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Borislav Petkov <bp@alien8.de> - 2015-09-24 21:20 +0200
        Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Toshi Kani <toshi.kani@hpe.com> - 2015-09-24 22:10 +0200
          Re: [PATCH v2 2/2] EDAC: Fix sysfs dimm_label store operation Borislav Petkov <bp@alien8.de> - 2015-09-25 20:00 +0200

csiph-web