Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1232946
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ASoC: sgtl5000: fix bad register MIC_BIAS_VOLTAGE setup on probe |
| Date | 2015-09-25 19:00 +0200 |
| Message-ID | <qcEvM-7fp-19@gated-at.bofh.it> (permalink) |
| References | <qcEvM-7fp-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Fri, Sep 25, 2015 at 04:21:27PM +0200, Gianluca Renzi wrote:
> snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
> SGTL5000_BIAS_R_MASK,
> - sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
> + sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);
That doesn't look right... I would expect _BIAS_R_SHIFT to shift a
value into the register masked off by _BIAS_R_MASK and therefore that
the above is saying that the definition of one of those two macros is
wrong. I would not expect something called _BIAS_VOLT_SHIFT here.
What's going on here?
> @@ -1549,7 +1549,7 @@ static int sgtl5000_i2c_probe(struct i2c
> else {
> sgtl5000->micbias_voltage = 0;
> dev_err(&client->dev,
> - "Unsuitable MicBias resistor\n");
> + "Unsuitable MicBias voltage\n");
> }
This looks like a reasonable but unrelated fix and should be in a
separate patch.
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] ASoC: sgtl5000: fix bad register MIC_BIAS_VOLTAGE setup on probe Mark Brown <broonie@kernel.org> - 2015-09-25 19:00 +0200 Re: [alsa-devel] [PATCH] ASoC: sgtl5000: fix bad register MIC_BIAS_VOLTAGE setup on probe Fabio Estevam <festevam@gmail.com> - 2015-09-25 19:10 +0200
csiph-web