Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	John Youn <John.Youn@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode
Date	Thu, 24 Sep 2015 06:30:02 +0200
Message-ID	<qc6kq-DF-3@gated-at.bofh.it> (permalink)
References	<q7lap-2Bn-3@gated-at.bofh.it>
X-Original-To	Scott Branden <sbranden@broadcom.com>, John Youn <John.Youn@synopsys.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, Roman Bacik <rbacik@broadcom.com>
Thread-Topic	[PATCH v3 0/1] USB DWC2 parity fix in isochronous mode
Thread-Index	AQHQ7C8tdR+06JjRfkaZrOIYT7QRAw==
Accept-Language	en-US
Content-Language	en-US
X-Originating-IP	[10.10.161.122]
Content-Type	text/plain; charset="us-ascii"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bcm-kernel-feedback-list@broadcom.com" <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Thu, 24 Sep 2015 04:21:16 +0000
X-Original-Message-ID	<2B3535C5ECE8B5419E3ECBE30077290901DC37A295@US01WEMBX2.internal.synopsys.com>
X-Original-References	<1441934023-6557-1-git-send-email-sbranden@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1231846

Show key headers only | View raw

On 9/10/2015 6:14 PM, Scott Branden wrote:
> This patch contains a fix for a real world interop problem found
> when using the Synopsis DWC2 USB controller with isochronous audio as
> detailed in the commit message.
> 
> Changes from v2:
>  - created s2c_hsotg_chage_ep_iso_parity function to call function in 3 places in code
>  - used hsotg->num_of_eps instead of MAX_EPS_CHANNELS
> 
> Changes from v1:
>  - Address code review comments as per previous responses:
>  - renamed parity_set to has_correct_parity and reorder some logic
> 
> 
> Roman Bacik (1):
>   usb: dwc2: gadget: parity fix in isochronous mode
> 
>  drivers/usb/dwc2/core.h   |  1 +
>  drivers/usb/dwc2/gadget.c | 58 ++++++++++++++++++++++++++++++++++++++++++-----
>  drivers/usb/dwc2/hw.h     |  1 +
>  3 files changed, 54 insertions(+), 6 deletions(-)
> 

This seems to break slave mode on my platform. It seems to be
dropping a lot of packets. I tried bInterval=4,5,6, ISO OUT.
I'll need to take a closer look to determine why. Probably later
this week.

Are you able to run in slave mode on your platform? If so can you
try it out?

Regards,
John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode John Youn <John.Youn@synopsys.com> - 2015-09-24 06:30 +0200
  RE: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode Roman Bacik <rbacik@broadcom.com> - 2015-09-24 19:30 +0200
    Re: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode John Youn <John.Youn@synopsys.com> - 2015-09-25 05:20 +0200
      RE: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode Roman Bacik <rbacik@broadcom.com> - 2015-09-28 17:30 +0200

csiph-web