Re: [PATCH 3/5] locking/rtmutex: Use acquire/release semantics

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Davidlohr Bueso <dave@stgolabs.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] locking/rtmutex: Use acquire/release semantics
Date	Tue, 22 Sep 2015 18:00:02 +0200
Message-ID	<qby94-1o7-19@gated-at.bofh.it> (permalink)
References	<qbfJ7-fE-3@gated-at.bofh.it> <qbfJ8-fE-15@gated-at.bofh.it> <qbxPI-10s-39@gated-at.bofh.it>
X-Original-To	Thomas Gleixner <tglx@linutronix.de>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii; format=flowed
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Will Deacon <will.deacon@arm.com>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
X-Original-Date	Tue, 22 Sep 2015 08:55:42 -0700
X-Original-Message-ID	<20150922155542.GA2682@linux-q0g1.site>
X-Original-References	<1442866676-10359-1-git-send-email-dave@stgolabs.net> <1442866676-10359-4-git-send-email-dave@stgolabs.net> <alpine.DEB.2.11.1509221732460.5606@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1230377

Show key headers only | View raw

On Tue, 22 Sep 2015, Thomas Gleixner wrote:

>> @@ -121,11 +130,14 @@ static inline bool unlock_rt_mutex_safe(struct rt_mutex *lock)
>>  	 *					lock(wait_lock);
>>  	 *					acquire(lock);
>>  	 */
>> -	return rt_mutex_cmpxchg(lock, owner, NULL);
>> +	return rt_mutex_cmpxchg_acquire(lock, owner, NULL);
>
>Why is this acquire?

Because I am an idiot, that should be a release...

Thanks,
Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/5] locking: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-21 22:20 +0200
  [PATCH 4/5] locking/rwsem: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-21 22:20 +0200
    Re: [PATCH 4/5] locking/rwsem: Use acquire/release semantics Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-21 22:40 +0200
    [PATCH v2] locking/rwsem: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-24 03:10 +0200
  [PATCH 3/5] locking/rtmutex: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-21 22:20 +0200
    Re: [PATCH 3/5] locking/rtmutex: Use acquire/release semantics Thomas Gleixner <tglx@linutronix.de> - 2015-09-22 17:40 +0200
      Re: [PATCH 3/5] locking/rtmutex: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-22 18:00 +0200
    [PATCH v2] locking/rtmutex: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-24 03:10 +0200
      Re: [PATCH v2] locking/rtmutex: Use acquire/release semantics Thomas Gleixner <tglx@linutronix.de> - 2015-09-27 12:40 +0200
        Re: [PATCH v2] locking/rtmutex: Use acquire/release semantics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-28 22:00 +0200
          Re: [PATCH v2] locking/rtmutex: Use acquire/release semantics Thomas Gleixner <tglx@linutronix.de> - 2015-09-29 23:00 +0200
  [PATCH 1/5] asm-generic: Add _{relaxed|acquire|release}() variants for inc/dec atomics Davidlohr Bueso <dave@stgolabs.net> - 2015-09-21 22:20 +0200

csiph-web